update merge #16
Merged
update merge #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1158) Last one before I add the actual linter rules!
Co-authored-by: Jed Fox <[email protected]>
Looks like this got missed in the last PR!
* Provide `match` prop to class components that still rely on it. * Fixes #1169 * Fixes an unrelated crash on Payees
#1173) - New linter rules are now added - Perhaps the `createPayee` method i've tagged with a disable should be deleted. - I have ignored unused methods in Plaid/Mobile as this stuff is still WIP/experimental?
Also remove the need to unmount & remount when switching between accounts. Fixes #1169
I've updated the return values in `sync/index` to sensible values based on how they're being called. I've updated the type of `msg.value` to be `string | number | null` to match the values expected by `serializeValue`
Based on Tom's comment (#1058 (comment)) I've eliminated all direct use of date-fns and only use the functions in months.ts. --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
Just removing some unused/unnecessary scripts and `IS_BETA` env variable + the associated code (we don't use this in the OS version of Actual).
It me it seems the monkey patch is no longer necessary.. At least I'm not able to reproduce any `escape` key related issues. But LMK what you think. The `@reach/listbox` component is used for the custom select component (for example: for filters).
Another monkeypatch bites the dust. AFAIK there is no regression in functionality. But please test yourselves too to double check.
I checked through the other references to `navigate` and none of them appeared to be affected.
This will reduce install/lockfile size but won’t affect the built bundle size. Still nice, hopefully!
This fixes an error that you’ll see about an unused export if you build before linting.
This significantly speeds up `yarn lint` for me. It also ensures we’re listing all source files in the project, including the `.eslintrc` files and any other files that may be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.