Goals: Use shared 'months' functions for time #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
👋 Hey! Is this PR out for review? If so - would you mind converting it from draft? And also CI is failing. If this is still work in progress: would you mind prefixing the PR title with "[WIP]"? Thanks! |
I won't have time for a couple of weeks to check for errors (vacation). I'll mark as WIP for now. |
|
Amazing, thanks @shall0pass ! Enjoy your well deserved time off! :) |
shall0pass
commented
Jun 15, 2023
| target_month = addMonths(target_month, repeat); | ||
| num_months = differenceInCalendarMonths( | ||
| target_month = monthUtils.addMonths(target_month, repeat); | ||
| num_months = monthUtils.differenceInCalendarMonths( | ||
| template_lines[l], |
There was a problem hiding this comment.
I couldn't find a situation where this code is run, but we should be passig the month parameter instead of the whole template line.
shall0pass
changed the title
MatissJanis
approved these changes
Jun 25, 2023
j-f1
approved these changes
Jun 25, 2023
trafico-bot
bot
added
✨ Merged
TomAFrench
added a commit
to TomAFrench/actual
that referenced
this pull request
Jun 26, 2023
* master: ⬆️ upgrade @reach/listbox and remove monkeypatch (actualbudget#1190) 🔥 remove beta code and some unused scripts (actualbudget#1189) Goals: Use shared 'months' functions for time (actualbudget#1082) Fix completed feature request handling (actualbudget#1183) Fix “delete file” modal layout (actualbudget#1170) chore: enforce proper types in `sync/index` (actualbudget#1077) Fix transaction list page being blank on mobile (actualbudget#1171) Automatic category selection for new category transactions (actualbudget#1176)
TomAFrench
added a commit
to TomAFrench/actual
that referenced
this pull request
Jun 26, 2023
* master: ⬆️ upgrade @reach/listbox and remove monkeypatch (actualbudget#1190) 🔥 remove beta code and some unused scripts (actualbudget#1189) Goals: Use shared 'months' functions for time (actualbudget#1082)
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Based on Tom's comment (actualbudget#1058 (comment)) I've eliminated all direct use of date-fns and only use the functions in months.ts. --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Tom's comment (#1058 (comment)) I've eliminated all direct use of date-fns and only use the functions in months.ts.