Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Updates: group notifications and identifiers cache #877

Merged

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Dec 19, 2024

Description

Refresh notification after group initiator has proposed a cred.

Credential request notification be marked unread and the count increased by +1 once the initiator has proposed a credential to the group.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1601

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Refresh notification when group initiator proposed a cred

Screen.Recording.2024-12-19.at.15.13.44.mov

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the feat/DTIS-1601-refresh-credential-request-notification branch from 9583fb2 to 363570a Compare December 19, 2024 07:57
@Sotatek-DukeVu Sotatek-DukeVu removed the request for review from iFergal December 19, 2024 08:18
@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Dec 19, 2024
@Sotatek-DukeVu Sotatek-DukeVu marked this pull request as ready for review December 19, 2024 08:18
@sdisalvo-crd sdisalvo-crd merged commit 7cc49de into develop Dec 19, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1601-refresh-credential-request-notification branch December 19, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants