Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh IPEX notifications on major signing events #870

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Dec 13, 2024

Description

This PR allows the UI to more closely match our notifications design for group IPEX for refreshing. Refreshing here means marking the notification as unread, and setting it's createdAt date to now. We will be renaming createdAt in the future to better reflect this.

Changes:

  • When the leader accepts a credential, the notification will be refreshed for other members
  • When the leader proposes a credential from a request, the notification will be refreshed for other members
  • When a credential presentation meets the threshold, the notification will be refreshed for all members instead of being removed

When the threshold is met for receiving a credential, the notification will still be deleted because the user can see that the credential went from pending to confirmed. (There is connection history, but this is less obvious)

Finally, I've introduced a groupReplied field for notification details in the list. Based on Robert's designs, the text of the notification should say "X has proposed a credential for Y's request" once the leader has proposed something. This should be tackled in the current UI ticket.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: No

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

@iFergal iFergal self-assigned this Dec 13, 2024
@jimcase jimcase merged commit c7b87c6 into develop Dec 17, 2024
1 check passed
@iFergal iFergal deleted the feat/refreshIpexNotifications2 branch December 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants