Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Standardise pages layout: Set Passcode #254

Merged

Conversation

sdisalvo-crd
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd commented Nov 14, 2023

Description

Standardise pages layout: Set Passcode.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-406

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

16112023150504

Android

16112023150536

Browser

16112023144329.mp4

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-lci6mhnpv.vercel.app

@sdisalvo-crd sdisalvo-crd marked this pull request as ready for review November 16, 2023 15:14
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-iqs00n99w.vercel.app

@sdisalvo-crd sdisalvo-crd requested a review from jimcase November 16, 2023 15:27
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-igbmp98ob.vercel.app

@sdisalvo-crd sdisalvo-crd merged commit 713586e into develop Nov 16, 2023
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-406-UI-StandardisePages_PageLayOut-setpasscode branch November 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants