Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Standardise pages - Onboarding page layout #253

Merged

Conversation

sdisalvo-crd
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd commented Nov 13, 2023

Description

Apply standardised page layout to Onboarding.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-405

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

13112023154640

Android

13112023154725

@sdisalvo-crd sdisalvo-crd self-assigned this Nov 13, 2023
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-91x76lpax.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-c1a64b1wg.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-24ryn5uvj.vercel.app

@sdisalvo-crd sdisalvo-crd marked this pull request as ready for review November 13, 2023 15:48
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-8q7n6oeeq.vercel.app

@sdisalvo-crd sdisalvo-crd requested a review from jimcase November 13, 2023 15:54
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-kq7w9lp73.vercel.app

@sdisalvo-crd sdisalvo-crd merged commit ca5bdb1 into develop Nov 14, 2023
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-405-UI-StandardisePages_PageLayOut-onboarding branch November 14, 2023 10:34
@robsalaman
Copy link

robsalaman commented Nov 14, 2023

@sdisalvo-crd Overall this looks great; however, it would be good if the paddings on the left-right would be more prominent on the paragraph, as per the designs, when on larger devices and then get smaller when going into the smaller viewports 😃

@sdisalvo-crd
Copy link
Contributor Author

@sdisalvo-crd Overall this looks great; however, it would be good if the paddings on the left-right would be more prominent on the paragraph, as per the designs, when on larger devices and then get smaller when going into the smaller viewports 😃

Thanks @robsalaman and sorry for merging too early. I'll add these changes to my next PR.

14112023115107

14112023115511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants