Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-wallet-jormungandr: tweak error message style #886

Merged
merged 2 commits into from
Oct 23, 2019
Merged

cardano-wallet-jormungandr: tweak error message style #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
355b03a
cardano-wallet-jormungandr: tweak error message style
rvl Oct 23, 2019
1ff90b7
fix integration tests accordingly: error has changed
KtorZ Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/jormungandr/exe/cardano-wallet-jormungandr.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,6 @@ extraArguments = many $ argument jmArg $ mempty
| "--storage" `isPrefixOf` arg = Just $
suggestion "--storage"
| otherwise = Nothing
suggestion arg = "The " <> arg <> " argument is used by the launch command."
<> "\nIf you need this level of flexibility, run \"jormungandr\" "
<> "separately and use \"cardano-wallet-jormungandr serve\"."
suggestion arg = "The " <> arg <> " option is used by the 'launch'"
<> " command.\nIf you need to use this option,"
<> " run Jörmungandr separately and use 'serve'."
4 changes: 2 additions & 2 deletions lib/jormungandr/test/integration/Test/Integration/Jormungandr/Scenario/CLI/Launcher.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ spec = do
(Exit c, Stdout _, Stderr e) <- cardanoWalletCLI @t args
c `shouldBe` ExitFailure 1
e `shouldContain`
"The --rest-listen argument is used by the launch command."
"The --rest-listen option is used by the 'launch' command."

it "LAUNCH - Conflicting --storage in extra arguments" $ do
let args =
Expand All @@ -171,7 +171,7 @@ spec = do
(Exit c, Stdout _, Stderr e) <- cardanoWalletCLI @t args
c `shouldBe` ExitFailure 1
e `shouldContain`
"The --storage argument is used by the launch command."
"The --storage option is used by the 'launch' command."

it "LAUNCH - Restoration workers restart" $ withTempDir $ \d -> do
pendingWith
Expand Down