cardano-wallet-jormungandr: tweak error message style #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
approved these changes
Oct 23, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
880: Jormungandr 0.7.0 r=KtorZ a=piotr-iohk
# Issue Number
# Overview
<!-- Detail in a few bullet points the work accomplished in this PR -->
- [ ] ~Jormungandr 0.7.0-alpha.dev~
- [ ] Jormungandr 0.7.0-alpha.dev.1
# Comments
It works fine with `jormungandr + cardano-wallet-jormungandr serve` but doesn't work with launch...
```
$cardano-wallet-jormungandr launch --genesis-block block0.bin -- --secret secret.yaml
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Using directory: /home/piotr/.local/share/cardano-wallet/jormungandr/testnet
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Using directory: /home/piotr/.local/share/cardano-wallet/jormungandr/testnet/wallets
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Running as v2019.10.16
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Wallet backend server starting...
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Node is Jörmungandr on testnet
[iohk.cardano-wallet:Info:ThreadId 4] [2019-10-22 09:55:55.38 UTC] Generated Jörmungandr's configuration to: /home/piotr/.local/share/cardano-wallet/jormungandr/testnet/jormungandr-config.yaml
[iohk.cardano-wallet:Notice:ThreadId 4] [2019-10-22 09:55:55.39 UTC] Starting process jormungandr
--genesis-block block0.bin
--config /home/piotr/.local/share/cardano-wallet/jormungandr/testnet/jormungandr-config.yaml
--log-level info
--secret secret.yaml
[iohk.cardano-wallet.jormungandr.14208:Info:ThreadId 4] [2019-10-22 09:55:55.39 UTC] Process jormungandr started with pid 14208
Oct 22 11:55:55.396 INFO Starting jormungandr 0.7.0-alpha.dev (HEAD-61fa897, release, linux [x86_64]) - [rustc 1.38.0 (625451e37 2019-09-23)], task: init
Oct 22 11:55:55.396 INFO Starting 1 workers, scope: global
Oct 22 11:55:55.396 INFO Starting server on 127.0.0.1:33671, scope: global
Oct 22 11:55:55.397 INFO storing blockchain in '"/home/piotr/.local/share/cardano-wallet/jormungandr/testnet/chain/blocks.sqlite"', task: init
Oct 22 11:55:55.406 ERRO Error occurred during request handling, status: 503 Service Unavailable Full REST context not available yet, scope: global
cardano-wallet-jormungandr: ErrUnexpectedNetworkFailure (Link {_segments = ["api","v0","block","4c05c5bb1dfa2848a2a36249b28d97ef8e6c77c7cb1f9626d1c4024c2470a2c2"], _queryParams = []}) (FailureResponse (Response {responseStatusCode = Status {statusCode = 503, statusMessage = "Service Unavailable"}, responseHeaders = fromList [("content-length","0"),("date","Tue, 22 Oct 2019 09:55:55 GMT")], responseHttpVersion = HTTP/1.1, responseBody = ""}))
```
886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl
Relates to #848.
# Overview
Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862.
Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
Canceled (will resume) |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
KtorZ
force-pushed
the
rvl/848/tweak-help-text
branch
from
ae6bfb8 to
1ff90b7
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
881: Connect Pool DB with Api r=KtorZ a=Anviking # Issue Number #713 # Overview - [x] I have implemented a `GET /stake-pool` that reads and combines metrics from `Pool.DB` - [x] TODO: Figure out when we are unsynced - [ ] TODO: Look for things to test if possible in this PR # Comments ### Self-node with a very short epoch-length (results are unavailable across epoch boundaries)  ### Testnet syncing which is interrupted and resumed  <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 884: More integration tests for Byron wallets r=KtorZ a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] More integration tests for Byron wallets ensuring that Shelley endpoints/CLI cannot manage them # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
884: More integration tests for Byron wallets r=KtorZ a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] More integration tests for Byron wallets ensuring that Shelley endpoints/CLI cannot manage them # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 886: cardano-wallet-jormungandr: tweak error message style r=KtorZ a=rvl Relates to #848. # Overview Addresses this [review comment](#862 (comment)) from @piotr-iohk on #862. Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #848.
Overview
Addresses this review comment from @piotr-iohk on #862.