Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3058] Integrate new migrations into the db layer on disk operations. #3985

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[ADP-3058] Integrate new migrations into the db layer on disk operations. #3985

merged 1 commit into from
Jun 6, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 6, 2023

This is just a patch to #3977, where I just remembered that I needed to unstash the final commit.

ADP-3058

@paolino paolino requested a review from HeinrichApfelmus June 6, 2023 11:07
@paolino paolino self-assigned this Jun 6, 2023
@paolino paolino force-pushed the paolino/ADP-3058/integrate-new-migration-library-patch branch 2 times, most recently from 303753c to bb3aedc Compare June 6, 2023 11:42
HeinrichApfelmus
HeinrichApfelmus approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊 Two requests: Slightly more useful place for the old tracer, import formatting.

lib/wallet/src/Cardano/DB/Sqlite.hs Outdated Show resolved Hide resolved
lib/wallet/src/Cardano/DB/Sqlite.hs Outdated Show resolved Hide resolved
lib/wallet/src/Cardano/DB/Sqlite.hs Show resolved Hide resolved
lib/wallet/src/Cardano/DB/Sqlite.hs Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3058/integrate-new-migration-library-patch branch from bb3aedc to 1ae3fe1 Compare June 6, 2023 14:02
@paolino
Copy link
Collaborator Author

paolino commented Jun 6, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 6, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit cd5a763 into master Jun 6, 2023
@iohk-bors iohk-bors bot deleted the paolino/ADP-3058/integrate-new-migration-library-patch branch June 6, 2023 15:32
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jun 6, 2023
docs: Merge #3985 3985: [ADP-3058] Integrate new migrations into the …
4d34989 
…db layer on disk operations. r=paolino a=paolino This is just a patch to #3977, where I just remembered that I needed to unstash the final commit.
 
 ADP-3058
 Co-authored-by: paolino <[email protected]> Source commit: cd5a763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus