Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3058] Implement MigrationInterface for SQLite #3977

Merged
merged 4 commits into from
Jun 5, 2023
Merged

[ADP-3058] Implement MigrationInterface for SQLite #3977

merged 4 commits into from
Jun 5, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 4, 2023

@paolino paolino self-assigned this Jun 4, 2023
@paolino paolino force-pushed the paolino/ADP-3058/integrate-new-migration-library branch 4 times, most recently from 1d1dd5e to bc3c690 Compare June 5, 2023 11:47
@paolino paolino marked this pull request as ready for review June 5, 2023 11:47
@paolino paolino requested a review from HeinrichApfelmus June 5, 2023 11:47
@paolino paolino force-pushed the paolino/ADP-3058/integrate-new-migration-library branch from bc3c690 to 1ed4b95 Compare June 5, 2023 12:31
@paolino paolino force-pushed the paolino/ADP-3058/integrate-new-migration-library branch from 1ed4b95 to bac8caf Compare June 5, 2023 15:03
HeinrichApfelmus
HeinrichApfelmus approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊 (I have changed the title to better reflect the new scope of the PR.)

@HeinrichApfelmus HeinrichApfelmus changed the title [ADP-3058] Integrate new migration library. [ADP-3058] Implement MigrationInterface for SQLite Jun 5, 2023
@paolino
Copy link
Collaborator Author

paolino commented Jun 5, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 5, 2023
@iohk-bors @paolino
Merge #3977
781259f 
3977: [ADP-3058] Implement `MigrationInterface` for SQLite r=paolino a=paolino

ADP-3058


Co-authored-by: paolino <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 5, 2023

Build failed:

@paolino
Copy link
Collaborator Author

paolino commented Jun 5, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 5, 2023
@iohk-bors @paolino
Merge #3977
142f680 
3977: [ADP-3058] Implement `MigrationInterface` for SQLite r=paolino a=paolino

ADP-3058


Co-authored-by: paolino <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 5, 2023

Build failed:

@paolino
Copy link
Collaborator Author

paolino commented Jun 5, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 5, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 4711f93 into master Jun 5, 2023
@iohk-bors iohk-bors bot deleted the paolino/ADP-3058/integrate-new-migration-library branch June 5, 2023 20:21
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jun 5, 2023
docs: Merge #3977 3977: [ADP-3058] Implement MigrationInterface for…
fe00649 
… SQLite r=paolino a=paolino ADP-3058
 Co-authored-by: paolino <[email protected]> Source commit: 4711f93
@paolino paolino mentioned this pull request Jun 6, 2023
Merged
iohk-bors bot added a commit that referenced this pull request Jun 6, 2023
@iohk-bors @paolino
Merge #3985
cd5a763 
3985: [ADP-3058] Integrate new migrations into the db layer on disk operations. r=paolino a=paolino

This is just a patch to #3977, where I just remembered that I needed to unstash the final commit.

ADP-3058


Co-authored-by: paolino <[email protected]>
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jun 6, 2023
docs: Merge #3985 3985: [ADP-3058] Integrate new migrations into the …
4d34989 
…db layer on disk operations. r=paolino a=paolino This is just a patch to #3977, where I just remembered that I needed to unstash the final commit.
 
 ADP-3058
 Co-authored-by: paolino <[email protected]> Source commit: cd5a763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus