Integration tests for list addresses with filtering and outstanding list addresses tests via CLI #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Jun 11, 2019
| , "-1000" | ||
| , "44444444" | ||
| , "*" | ||
| ] |
| , "?state=-1000" | ||
| , "?state=44444444" | ||
| , "?state=*" | ||
| ] |
There was a problem hiding this comment.
No variable vertical alignement please :)
There was a problem hiding this comment.
Will I ever learn? 😅 Fixed.
| if (title == "40 chars hex") then | ||
| c `shouldBe` ExitSuccess | ||
| else | ||
| c `shouldBe` ExitFailure 1 |
There was a problem hiding this comment.
Quite unrelated but this is odd? Do we return a success on 404?
There was a problem hiding this comment.
Yes, I think so too, but I was told that this is expected... ;) -> #278 (comment)
There was a problem hiding this comment.
Then I've very poorly expressed myself. I meant that you were right and that this oddity is not correct. May you open a bug ticket to keep track of that please?
There was a problem hiding this comment.
Ah, ok. My bad for misunderstanding then. Will open a bug 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#356
Overview
Comments