-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering by address state when fetching all addresses #356
Comments
@KtorZ Can we rename this task to something like:
(It seems clearer than the current title, which appears to describe a side effect of completing this task.) |
Fix available: #372 |
@jonathanknowles it seems to be ready to move to QA? (related integration tests added in #395) |
Yes, I believe this one is finished. |
Then let's fill in the QA section properly and move it to the appropriate section 🙏 |
Done. Implemented & tested. 👍 |
Context
In order to test transaction creation and submission, earlier on we had to implement the ability to list known addresses from the API. However, according to the specification, we should be able to filter known addresses by state (used vs unused).
See: Api Doc - listAddresses
Decision
Acceptance Criteria
state
must be supported by the API layer--only-used
and--only-unused
or an option--state=used|unused
to filter accordingly.Development Plan
PR
master
master
QA
#395 introduces integration tests against CLI and API for listing addresses with filters (tagged
ADDRESS_LIST_02
):CLI: https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/test/integration/Test/Integration/Scenario/CLI/Addresses.hs#L77-L134
API: https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/test/integration/Test/Integration/Scenario/API/Addresses.hs#L86-L132
The text was updated successfully, but these errors were encountered: