Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by address state when fetching all addresses #356

Closed
KtorZ opened this issue Jun 4, 2019 · 6 comments
Closed

Allow filtering by address state when fetching all addresses #356

KtorZ opened this issue Jun 4, 2019 · 6 comments
Assignees

Comments

@KtorZ
Copy link
Member

KtorZ commented Jun 4, 2019

Context

In order to test transaction creation and submission, earlier on we had to implement the ability to list known addresses from the API. However, according to the specification, we should be able to filter known addresses by state (used vs unused).

See: Api Doc - listAddresses

Decision

  • Allow filtering by address state when fetching all addresses

Acceptance Criteria

  1. Query parameter state must be supported by the API layer
  2. The Command line interface must have new option flags --only-used and --only-unused or an option --state=used|unused to filter accordingly.

Development Plan

PR

Number Base
#372 master
#395 master

QA

#395 introduces integration tests against CLI and API for listing addresses with filters (tagged ADDRESS_LIST_02):
CLI: https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/test/integration/Test/Integration/Scenario/CLI/Addresses.hs#L77-L134
API: https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/test/integration/Test/Integration/Scenario/API/Addresses.hs#L86-L132

@KtorZ KtorZ added the NEXT label Jun 4, 2019
@jonathanknowles
Copy link
Member

@KtorZ Can we rename this task to something like:

"Allow filtering by address state when fetching all addresses"

(It seems clearer than the current title, which appears to describe a side effect of completing this task.)

@KtorZ KtorZ changed the title Finalize List Addresses Allow filtering by address state when fetching all addresses Jun 5, 2019
@KtorZ KtorZ added PRIORITY[LOW] and removed NEXT labels Jun 5, 2019
@KtorZ KtorZ added this to the List Addresses milestone Jun 5, 2019
@jonathanknowles jonathanknowles self-assigned this Jun 6, 2019
@jonathanknowles
Copy link
Member

Fix available: #372

@piotr-iohk
Copy link
Contributor

@jonathanknowles it seems to be ready to move to QA? (related integration tests added in #395)

@jonathanknowles
Copy link
Member

@jonathanknowles it seems to be ready to move to QA? (related integration tests added in #395)

Yes, I believe this one is finished.

@KtorZ
Copy link
Member Author

KtorZ commented Jun 14, 2019

Then let's fill in the QA section properly and move it to the appropriate section 🙏

@piotr-iohk
Copy link
Contributor

Done. Implemented & tested. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants