More assets tests #2495
Merged
More assets tests #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
force-pushed
the
piotr/more-assets-tests-byron
branch
from
6ccf392 to
c113c35
Compare
rvl
approved these changes
Feb 8, 2021
| r <- request @(ApiAddress n) ctx (Link.postRandomAddress wB) Default p | ||
| expectSuccess r | ||
|
|
||
| -- pick out assets to send |
There was a problem hiding this comment.
It would be nice if the shelley wallet migration endpoint were available to use here...
| (`shouldNotBe` TokenMap.empty) | ||
| ] | ||
|
|
||
| describe "BYRON_TRANS_CREATE_01 - Single Output Transaction with non-Shelley witnesses" $ |
There was a problem hiding this comment.
Ah OK, so these are moved from the shelley file.
piotr-iohk
force-pushed
the
piotr/more-assets-tests-byron
branch
from
c113c35 to
24e6b3c
Compare
|
bors try |
tryBuild succeeded: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 9, 2021
2495: More assets tests r=rvl a=piotr-iohk # Issue Number ADP-603 # Overview - 5a9ddd5 Move Byron transaction tests to Byron suite - cd3e179 Byron asset tx tests - 0660ea6 Byron asset list/get tests - 24e6b3c Fix icarus asset endpoints # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed: A new one. The error seems to have no relation to the changes in this PR. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-603
Overview
5a9ddd5
Move Byron transaction tests to Byron suite
cd3e179
Byron asset tx tests
0660ea6
Byron asset list/get tests
24e6b3c
Fix icarus asset endpoints
Comments