Skip to content

Commit

Permalink
Move Byron transaction tests to Byron suite
Browse files Browse the repository at this point in the history
  • Loading branch information
Piotr Stachyra committed Feb 8, 2021
1 parent 6048753 commit 5a9ddd5
Show file tree
Hide file tree
Showing 3 changed files with 211 additions and 178 deletions.
33 changes: 33 additions & 0 deletions lib/core-integration/src/Test/Integration/Framework/DSL.hs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ module Test.Integration.Framework.DSL
, faucetAmt
, faucetUtxoAmt
, proc'
, postTx
, waitForServer
, for
, utcIso8601ToText
Expand Down Expand Up @@ -617,6 +618,38 @@ defaultTxTTL = 7200
--
-- Helpers
--

postTx
:: forall n w m.
( DecodeAddress n
, DecodeStakeAddress n
, EncodeAddress n
, HasType (ApiT WalletId) w
, MonadIO m
, MonadUnliftIO m
)
=> Context
-> (w, w -> (Method, Text), Text)
-> ApiWallet
-> Natural
-> m (HTTP.Status, Either RequestException (ApiTransaction n))
postTx ctx (wSrc, postTxEndp, pass) wDest amt = do
addrs <- listAddresses @n ctx wDest
let destination = (addrs !! 1) ^. #id
let payload = Json [aesonQQ|{
"payments": [{
"address": #{destination},
"amount": {
"quantity": #{amt},
"unit": "lovelace"
}
}],
"passphrase": #{pass}
}|]
r <- request @(ApiTransaction n) ctx (postTxEndp wSrc) Default payload
expectResponseCode HTTP.status202 r
return r

updateMetadataSource :: (MonadIO m, MonadUnliftIO m) => Context -> Text -> m ()
updateMetadataSource ctx t = do
r <- request @SettingsPutData ctx Link.putSettings Default payload
Expand Down
170 changes: 169 additions & 1 deletion lib/core-integration/src/Test/Integration/Scenario/API/Byron/Transactions.hs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,21 @@ import Prelude

import Cardano.Wallet.Api.Types
( ApiByronWallet
, ApiFee (..)
, ApiTransaction
, ApiTxId (..)
, ApiWallet
, DecodeAddress
, DecodeStakeAddress
, EncodeAddress (..)
, WalletStyle (..)
)
import Cardano.Wallet.Primitive.AddressDerivation
( PaymentAddress )
import Cardano.Wallet.Primitive.AddressDerivation.Icarus
( IcarusKey )
import Cardano.Wallet.Primitive.Types.Tx
( Direction (..), TxStatus (..) )
import Control.Monad
( forM_ )
import Control.Monad.IO.Class
Expand All @@ -34,6 +44,8 @@ import Data.Quantity
( Quantity (..) )
import Data.Text.Class
( fromText )
import Numeric.Natural
( Natural )
import Test.Hspec
( SpecWith, describe )
import Test.Hspec.Expectations.Lifted
Expand All @@ -44,22 +56,34 @@ import Test.Integration.Framework.DSL
( Context
, Headers (..)
, Payload (..)
, between
, emptyIcarusWallet
, emptyRandomWallet
, emptyWallet
, eventually
, expectErrorMessage
, expectField
, expectListSize
, expectResponseCode
, expectSuccess
, expectSuccess
, faucetAmt
, faucetUtxoAmt
, fixtureIcarusWallet
, fixturePassphrase
, fixtureRandomWallet
, fixtureWallet
, getFromResponse
, json
, listAddresses
, minUTxOValue
, postByronWallet
, postTx
, request
, toQueryString
, verify
, walletId
, (.>=)
)
import Test.Integration.Framework.Request
( RequestException )
Expand All @@ -78,8 +102,152 @@ data TestCase a = TestCase
spec :: forall n.
( DecodeAddress n
, DecodeStakeAddress n
, EncodeAddress n
, PaymentAddress n IcarusKey
) => SpecWith Context
spec = describe "BYRON_MIGRATIONS" $ do
spec = describe "BYRON_TRANSACTIONS" $ do

describe "BYRON_TRANS_CREATE_01 - Single Output Transaction with non-Shelley witnesses" $
forM_ [(fixtureRandomWallet, "Byron wallet"), (fixtureIcarusWallet, "Icarus wallet")] $
\(srcFixture,name) -> it name $ \ctx -> runResourceT $ do

(wByron, wShelley) <- (,) <$> srcFixture ctx <*> fixtureWallet ctx
addrs <- listAddresses @n ctx wShelley

let amt = minUTxOValue :: Natural
let destination = (addrs !! 1) ^. #id
let payload = Json [json|{
"payments": [{
"address": #{destination},
"amount": {
"quantity": #{amt},
"unit": "lovelace"
}
}]
}|]

rFeeEst <- request @ApiFee ctx
(Link.getTransactionFee @'Byron wByron) Default payload
verify rFeeEst
[ expectSuccess
, expectResponseCode HTTP.status202
]
let (Quantity feeEstMin) = getFromResponse #estimatedMin rFeeEst
let (Quantity feeEstMax) = getFromResponse #estimatedMax rFeeEst

r <- postTx @n ctx
(wByron, Link.createTransaction @'Byron, fixturePassphrase)
wShelley
amt
verify r
[ expectSuccess
, expectResponseCode HTTP.status202
, expectField (#amount . #getQuantity) $
between (feeEstMin + amt, feeEstMax + amt)
, expectField (#direction . #getApiT) (`shouldBe` Outgoing)
, expectField (#status . #getApiT) (`shouldBe` Pending)
]

ra <- request @ApiByronWallet ctx (Link.getWallet @'Byron wByron) Default Empty
verify ra
[ expectSuccess
, expectField (#balance . #total) $
between
( Quantity (faucetAmt - feeEstMax - amt)
, Quantity (faucetAmt - feeEstMin - amt)
)
, expectField
(#balance . #available)
(.>= Quantity (faucetAmt - faucetUtxoAmt))
]

eventually "wa and wb balances are as expected" $ do
rb <- request @ApiWallet ctx
(Link.getWallet @'Shelley wShelley) Default Empty
expectField
(#balance . #available)
(`shouldBe` Quantity (faucetAmt + amt)) rb

ra2 <- request @ApiByronWallet ctx
(Link.getWallet @'Byron wByron) Default Empty
expectField
(#balance . #available)
(`shouldBe` Quantity (faucetAmt - feeEstMax - amt)) ra2

it "BYRON_TRANS_CREATE_02 -\
\ Cannot create tx on Byron wallet using shelley ep" $ \ctx -> runResourceT $ do
w <- emptyRandomWallet ctx
let wid = w ^. walletId
wDest <- emptyWallet ctx
addr:_ <- listAddresses @n ctx wDest
let destination = addr ^. #id
let payload = Json [json|{
"payments": [{
"address": #{destination},
"amount": {
"quantity": #{minUTxOValue},
"unit": "lovelace"
}
}],
"passphrase": "cardano-wallet"
}|]
let endpoint = "v2/wallets/" <> wid <> "/transactions"
r <- request @(ApiTransaction n) ctx ("POST", endpoint) Default payload
expectResponseCode HTTP.status404 r
expectErrorMessage (errMsg404NoWallet wid) r

it "BYRON_TRANS_DELETE -\
\ Cannot delete tx on Byron wallet using shelley ep" $ \ctx -> runResourceT $ do
w <- emptyRandomWallet ctx
let wid = w ^. walletId
let txid = "3e6ec12da4414aa0781ff8afa9717ae53ee8cb4aa55d622f65bc62619a4f7b12"
let endpoint = "v2/wallets/" <> wid <> "/transactions/" <> txid
r <- request @ApiTxId ctx ("DELETE", endpoint) Default Empty
expectResponseCode HTTP.status404 r
expectErrorMessage (errMsg404NoWallet wid) r

it "BYRON_TRANS_ESTIMATE -\
\ Cannot estimate tx on Byron wallet using shelley ep" $ \ctx -> runResourceT $ do
w <- emptyRandomWallet ctx
let wid = w ^. walletId
wDest <- emptyWallet ctx
addr:_ <- listAddresses @n ctx wDest
let destination = addr ^. #id
let payload = Json [json|{
"payments": [{
"address": #{destination},
"amount": {
"quantity": #{minUTxOValue},
"unit": "lovelace"
}
}]
}|]
let endpoint = "v2/wallets/" <> wid <> "/payment-fees"
r <- request @ApiFee ctx ("POST", endpoint) Default payload
expectResponseCode HTTP.status404 r
expectErrorMessage (errMsg404NoWallet wid) r

it "BYRON_TX_LIST_02 -\
\ Byron endpoint does not list Shelley wallet transactions" $ \ctx -> runResourceT $ do
w <- emptyWallet ctx
let wid = w ^. walletId
let ep = ("GET", "v2/byron-wallets/" <> wid <> "/transactions")
r <- request @([ApiTransaction n]) ctx ep Default Empty
verify r
[ expectResponseCode HTTP.status404
, expectErrorMessage (errMsg404NoWallet wid)
]

it "BYRON_TX_LIST_03 -\
\ Shelley endpoint does not list Byron wallet transactions" $ \ctx -> runResourceT $ do
w <- emptyRandomWallet ctx
let wid = w ^. walletId
let ep = ("GET", "v2/wallets/" <> wid <> "/transactions")
r <- request @([ApiTransaction n]) ctx ep Default Empty
verify r
[ expectResponseCode HTTP.status404
, expectErrorMessage (errMsg404NoWallet wid)
]

it "BYRON_RESTORE_08 - Icarus wallet with high indexes" $ \ctx -> runResourceT $ do
-- NOTE
Expand Down
Loading

0 comments on commit 5a9ddd5

Please sign in to comment.