Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject SMASH URIs with paths #2285

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Reject SMASH URIs with paths #2285

merged 2 commits into from
Nov 3, 2020

Conversation

hasufell
Copy link
Contributor

Issue Number

ADP-502

Overview

Comments

This was tested locally against testnet.

The sqlite serialisation is a little more permissive.

@hasufell hasufell self-assigned this Oct 30, 2020
KtorZ
KtorZ approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, although I believe is a breaking change with regard to the command-line arguments. cardano-launcher and the Daedalus config will need adjustments.

@hasufell
Copy link
Contributor Author

Looks right, although I believe is a breaking change with regard to the command-line arguments. cardano-launcher and the Daedalus config will need adjustments.

Yep

@hasufell hasufell force-pushed the jospald/ADP-502/smash-url-no-api-path branch from 48d714b to 4060fab Compare November 2, 2020 10:25
This was referenced Nov 2, 2020
Closed
Merged
@hasufell
Copy link
Contributor Author

hasufell commented Nov 3, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 458c0fa into master Nov 3, 2020
@iohk-bors iohk-bors bot deleted the jospald/ADP-502/smash-url-no-api-path branch November 3, 2020 10:49
@Anviking Anviking mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@hasufell hasufell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasufell @KtorZ