Update documentation for PoolMetadataSource #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
commented
Nov 2, 2020
| @@ -31,7 +31,7 @@ import { DirPath } from './common'; | |||
| * - `'direct'` - enables fetching stake pool metadata from | |||
| * the registered pool URL. | |||
| * - otherwise, the URL of a SMASH metadata proxy server | |||
| * can be supplied. | |||
| * can be supplied. This must not contain the endpoint path. | |||
There was a problem hiding this comment.
Probably no point in validating it here in the code, or should we?
There was a problem hiding this comment.
Right, just have this option match the cardano-wallet CLI, and cardano-wallet can validate it if needed.
rvl
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: