Fix address prefixes on testnet

lib/core-integration/cardano-wallet-core-integration.cabal

@@ -63,6 +63,7 @@ library
     , http-client
     , http-types
     , iohk-monitoring
+    , lens-aeson
     , memory
     , optparse-applicative
     , process

lib/core-integration/src/Test/Integration/Framework/DSL.hs

@@ -265,6 +265,10 @@ import Data.Functor.Identity
     ( Identity (..) )
 import Data.Generics.Internal.VL.Lens
     ( Lens', lens, set, view, (^.) )
+import Data.Generics.Internal.VL.Prism
+    ( (^?) )
+import Data.Generics.Internal.VL.Traversal
+    ( Traversal' )
 import Data.Generics.Labels
     ()
 import Data.Generics.Product.Typed
@@ -406,20 +410,21 @@ expectResponseCode want (got, a) =
 
 expectField
     :: (HasCallStack, MonadIO m, Show a)
-    => Lens' s a
+    => Traversal' s a
     -> (a -> Expectation)
     -> (HTTP.Status, Either RequestException s)
     -> m ()
 expectField getter predicate (_, res) = case res of
     Left e  -> wantedSuccessButError e
-    Right s ->
-        let a = view getter s in
-        liftIO $ predicate a
+    Right s -> liftIO $ case s ^? getter of
+        Nothing -> expectationFailure
+            "could not traverse response to test expectations"
+        Just a -> predicate a
 
 expectListField
     :: (HasCallStack, MonadIO m, Show a)
     => Int
-    -> Lens' s a
+    -> Traversal' s a
     -> (a -> Expectation)
     -> (HTTP.Status, Either RequestException [s])
     -> m ()

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/Addresses.hs

@@ -33,7 +33,7 @@ import Data.Generics.Internal.VL.Lens
 import Data.Quantity
     ( Quantity (..) )
 import Test.Hspec
-    ( SpecWith, describe, shouldBe )
+    ( SpecWith, describe, shouldBe, shouldSatisfy )
 import Test.Hspec.Extra
     ( it )
 import Test.Integration.Framework.DSL
@@ -62,6 +62,7 @@ import Test.Integration.Framework.TestData
 
 import qualified Cardano.Wallet.Api.Link as Link
 import qualified Data.Aeson as Aeson
+import qualified Data.Aeson.Lens as Aeson
 import qualified Data.Text as T
 import qualified Network.HTTP.Types.Status as HTTP
 
@@ -226,6 +227,17 @@ spec = describe "SHELLEY_ADDRESSES" $ do
         expectResponseCode @IO HTTP.status404 r
         expectErrorMessage (errMsg404NoWallet $ w ^. walletId) r
 
+    it "ADDRESS_LIST_05 - bech32 HRP is correct - mainnet" $ \ctx -> do
+        w <- emptyWallet ctx
+        r <- request @[Aeson.Value] ctx
+            (Link.listAddresses @'Shelley w) Default Empty
+        verify r
+            [ expectResponseCode @IO HTTP.status200
+            -- integration tests are configured for mainnet
+            , expectListField 0 (Aeson.key "id" . Aeson._String)
+                (`shouldSatisfy` T.isPrefixOf "addr")
+            ]
+
     it "ADDRESS_INSPECT_01 - Address inspect OK" $ \ctx -> do
         let str = "Ae2tdPwUPEYz6ExfbWubiXPB6daUuhJxikMEb4eXRp5oKZBKZwrbJ2k7EZe"
         r <- request @Aeson.Value ctx (Link.inspectAddress str) Default Empty

lib/shelley/src/Cardano/Wallet/Shelley/Compatibility.hs

@@ -985,20 +985,20 @@ _decodeStakeAddress serverNetwork txt = do
         "Unable to decode stake-address: must be a valid bech32 string."
 
 instance EncodeAddress 'Mainnet where
-    encodeAddress = _encodeAddress
+    encodeAddress = _encodeAddress [Bech32.humanReadablePart|addr|]
 
 instance EncodeAddress ('Testnet pm) where
-    encodeAddress = _encodeAddress
+    -- https://github.com/cardano-foundation/CIPs/tree/master/CIP5
+    encodeAddress = _encodeAddress [Bech32.humanReadablePart|addr_test|]
 
-_encodeAddress :: W.Address -> Text
-_encodeAddress (W.Address bytes) =
+_encodeAddress :: Bech32.HumanReadablePart -> W.Address -> Text
+_encodeAddress hrp (W.Address bytes) =
     if isJust (CBOR.deserialiseCbor CBOR.decodeAddressPayload bytes)
         then base58
         else bech32
   where
     base58 = T.decodeUtf8 $ encodeBase58 bitcoinAlphabet bytes
     bech32 = Bech32.encodeLenient hrp (dataPartFromBytes bytes)
-    hrp = [Bech32.humanReadablePart|addr|]
 
 instance DecodeAddress 'Mainnet where
     decodeAddress = _decodeAddress SL.Mainnet

lib/shelley/test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs

@@ -161,6 +161,11 @@ spec = do
                     & counterexample (show $ base58 bytes)
                 ]
 
+        prop "Shelley addresses from bech32 - testnet" $ \k ->
+            let addr@(Address raw) = paymentAddress @('Testnet 0) @ShelleyKey k
+            in decodeAddress @('Testnet 0) (bech32testnet raw) === Right addr
+                   & counterexample (show $ bech32testnet raw)
+
         prop "Byron addresses from base16, bech32 and base58" $ \k -> do
             let addr@(Address bytes) = paymentAddress @'Mainnet @ByronKey k
             conjoin
@@ -378,5 +383,11 @@ bech32 :: ByteString -> Text
 bech32 = Bech32.encodeLenient hrp . Bech32.dataPartFromBytes
   where hrp = [humanReadablePart|addr|]
 
+-- Expected bech32 encoding for testnets
+-- https://github.com/cardano-foundation/CIPs/tree/master/CIP5
+bech32testnet :: ByteString -> Text
+bech32testnet = Bech32.encodeLenient hrp . Bech32.dataPartFromBytes
+  where hrp = [humanReadablePart|addr_test|]
+
 base58 :: ByteString -> Text
 base58 = T.decodeUtf8 . encodeBase58 bitcoinAlphabet