Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address prefixes on testnet #2273

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Fix address prefixes on testnet #2273

merged 4 commits into from
Oct 27, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Oct 27, 2020

Issue Number

ADP-493

Overview

  • Comply with CIP5 for payment addresses.
  • Tweak integration tests lensing stuff.

QA

  1. Manual tests with cardano-wallet serve --testnet.
  2. Integration test to check that bech32 addresses are still ok on mainnet.
  3. Unit test for testnet bech32 addresses.

@rvl rvl added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Oct 27, 2020
@rvl rvl requested a review from paweljakubas October 27, 2020 08:48
@rvl rvl self-assigned this Oct 27, 2020
paweljakubas
paweljakubas approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Would be good not to forgot to make sure hrp stake and stake_test for reward account are forced when we expose reward account (aka stake key) in API

@KtorZ
Copy link
Member

KtorZ commented Oct 27, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit d3cc1a6 into master Oct 27, 2020
@iohk-bors iohk-bors bot deleted the rvl/adp-493/addr_test branch October 27, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@KtorZ KtorZ KtorZ approved these changes

Assignees

@rvl rvl

Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvl @KtorZ @paweljakubas