Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Extra.it #2193

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Add tests for Extra.it #2193

merged 1 commit into from
Oct 2, 2020

Conversation

Anviking
Copy link
Member

Issue Number

#2192

Overview

Comments

@Anviking Anviking force-pushed the anviking/2192/test-custom-it branch 2 times, most recently from 204af50 to 3b70a69 Compare September 30, 2020 10:56
@Anviking Anviking self-assigned this Sep 30, 2020
@Anviking Anviking force-pushed the anviking/2192/test-custom-it branch from 3b70a69 to 4862a19 Compare September 30, 2020 10:58
@Anviking Anviking requested a review from KtorZ September 30, 2020 12:10
Anviking
Anviking commented Sep 30, 2020
View reviewed changes
lib/test-utils/test/Test/Hspec/ExtraSpec.hs Outdated
. filter (not . ("Randomized" `isPrefixOf`))
. lines
dynamically
:: IORef [Expectation]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be

Suggested change
:: IORef [Expectation]
:: IORef [IO ()]

@Anviking Anviking force-pushed the anviking/2192/test-custom-it branch from 28d90fb to b0c85e0 Compare October 1, 2020 14:46
@Anviking Anviking mentioned this pull request Oct 1, 2020
Merged
1 task
rvl
rvl approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the tests? Crazy! 👍

@rvl
Copy link
Contributor

rvl commented Oct 2, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 2, 2020
@iohk-bors @Anviking
Merge #2193
6c9286c 
2193: Add tests for Extra.it r=rvl a=Anviking

# Issue Number

#2192 


# Overview

- [x] I added a test suite for `cardano-wallet-test-utils` which could be useful
- [x] I added some basic tests for #2181


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 2, 2020 •
edited by Anviking
Loading

Build failed:

#2196

Failures:

   src/Test/Integration/Scenario/API/Shelley/StakePools.hs:151:9:
   1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01 - Cannot join existent stakepool with wrong password
        uncaught exception: IOException of type UserError
        user error (Pattern match failure in do expression at src/Test/Integration/Scenario/API/Shelley/StakePools.hs:151:9-14)

   To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01 - Cannot join existent stakepool with wrong password/"

   src/Test/Integration/Scenario/API/Shelley/StakePools.hs:158:5:
   2) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them
        uncaught exception: RequestException
        DecodeFailure "{\"code\":\"network_unreachable\",\"message\":\"The node backend is unreachable at the moment. Trying again in a bit might work.\"}"

   To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them/"

 ... doh ...

 Randomized with seed 1851824801

 Finished in 2944.5903 seconds
 659 examples, 20 failures, 3 pending

@Anviking
Copy link
Member Author

Anviking commented Oct 2, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 2, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 3a56413 into master Oct 2, 2020
@iohk-bors iohk-bors bot deleted the anviking/2192/test-custom-it branch October 2, 2020 05:44
This was referenced Oct 2, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

@KtorZ KtorZ Awaiting requested review from KtorZ

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @rvl