When a retried test fails, show the first error #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/2119/retry
branch
from
4bd41ff to
5d5c22c
Compare
If a test uses a finite resource, it cannot be retried, and will fail for another reason the second time. In this case, it is the first failure that is interesting. In other circumstances, showing the first error instead of the second should still be fine.
Anviking
force-pushed
the
anviking/2119/retry
branch
from
5d5c22c to
bcbce83
Compare
Anviking
added this to the (ADP-419) Make integration test output in CI more readable milestone
|
bors merge |
|
Build succeeded: |
This was referenced Sep 30, 2020
Merged
iohk-bors bot
added a commit
that referenced
this pull request
Oct 2, 2020
2193: Add tests for Extra.it r=rvl a=Anviking # Issue Number #2192 # Overview - [x] I added a test suite for `cardano-wallet-test-utils` which could be useful - [x] I added some basic tests for #2181 # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Oct 2, 2020
2193: Add tests for Extra.it r=Anviking a=Anviking # Issue Number #2192 # Overview - [x] I added a test suite for `cardano-wallet-test-utils` which could be useful - [x] I added some basic tests for #2181 # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2192
Overview
itattempt fails, show the first error, not the second.Comments
If a test uses a finite resource, it cannot be retried, and will fail for another reason the second time. In this case, it is the first failure that is interesting.
In other circumstances, showing the first error instead of the second should still be fine.
Haven't actually tried this yet. Should maybe do that. Or add a test suite for
test-utils.