Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Shelley specific transaction CLI tests from Jormungandr #2168

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Remove Shelley specific transaction CLI tests from Jormungandr #2168

merged 1 commit into from
Sep 25, 2020

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

#2020

Overview

  • 5291da5
    Remove Shelley specific transaction CLI tests from Jormungandr

Comments

Currently TRANSMETA_CREATE_01 - Transaction with metadata via CLI fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.

@piotr-iohk piotr-iohk added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Sep 23, 2020
@piotr-iohk piotr-iohk self-assigned this Sep 23, 2020
@piotr-iohk piotr-iohk requested a review from rvl September 23, 2020 08:31
@KtorZ
Copy link
Member

KtorZ commented Sep 23, 2020

bors merge

iohk-bors bot added a commit that referenced this pull request Sep 23, 2020
@iohk-bors
Merge #2168 #2171
37e8b51 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=KtorZ a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


2171: Fix metadata examples in swagger.yaml r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 4a547f9
  Fix metadata examples in swagger.yaml



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 23, 2020

Build failed (retrying...):

iohk-bors bot added a commit that referenced this pull request Sep 23, 2020
@iohk-bors
Merge #2168
e2ddfd6 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=KtorZ a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 23, 2020 •
edited by Anviking
Loading

Build failed:

Not quite sure, but looks like it is:
#expected

@piotr-iohk piotr-iohk force-pushed the piotr/remove-shelley-cli-tx-tests-from-jorm branch from 5291da5 to 22df990 Compare September 23, 2020 14:55
@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 23, 2020
@iohk-bors
Merge #2168
0772071 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 23, 2020 •
edited by Anviking
Loading

Build failed:

Timed out.
#2216

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 24, 2020
@iohk-bors
Merge #2168
c8d45c7 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 24, 2020 •
edited by Anviking
Loading

Timed out.
#2216

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 24, 2020
@iohk-bors
Merge #2168
e424943 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 24, 2020

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

iohk-bors bot added a commit that referenced this pull request Sep 24, 2020
@iohk-bors
Merge #2168
4b44550 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 24, 2020 •
edited by Anviking
Loading

Build failed:

#2118

Failures:

  test/unit/Cardano/Wallet/Primitive/FeeSpec.hs:379:9: 
  1) Cardano.Wallet.Primitive.Fee.prop_rebalanceSelection The fee balancing algorithm converges for any coin selection.
       Falsifiable (after 7960 tests):
         SaveMoney
         Coin {getCoin = 147770}
         selection (before):
         inputs: - 3rd 999038d5 (~ 199907 @ 61646472...64722d30)
         withdrawal: 777110
         reclaim: 637704
         outputs:
           - 113352 @ 61646472...64722d33
           - 187703 @ 61646472...64722d31
           - 84642 @ 61646472...64722d32
           - 192149 @ 61646472...64722d33
           - 48097 @ 61646472...64722d30
           - 30977 @ 61646472...64722d30
           - 35346 @ 61646472...64722d31
           - 47281 @ 61646472...64722d32
           - 110448 @ 61646472...64722d31
           - 119598 @ 61646472...64722d32
         change: [7424]
         deposit: 281458
         
         selection (after):
         inputs: - 3rd 999038d5 (~ 199907 @ 61646472...64722d30)
         withdrawal: 777110
         reclaim: 637704
         outputs:
           - 113352 @ 61646472...64722d33
           - 187703 @ 61646472...64722d31
           - 84642 @ 61646472...64722d32
           - 192149 @ 61646472...64722d33
           - 48097 @ 61646472...64722d30
           - 30977 @ 61646472...64722d30
           - 35346 @ 61646472...64722d31
           - 47281 @ 61646472...64722d32
           - 110448 @ 61646472...64722d31
           - 119598 @ 61646472...64722d32
         change: [147770]
         deposit: 281458
         
         delta (before): 356246
         delta (after):  215900
         total fee:      215900
         remaining fee:  0
         

  To rerun use: --match "/Cardano.Wallet.Primitive.Fee/prop_rebalanceSelection/The fee balancing algorithm converges for any coin selection./"

@piotr-iohk piotr-iohk mentioned this pull request Sep 24, 2020
Closed
@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 24, 2020
@iohk-bors
Merge #2168
76730e1 
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=piotr-iohk a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 24, 2020 •
edited by Anviking
Loading

Timed out.
#2216

@piotr-iohk
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 25, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit f5f689e into master Sep 25, 2020
@iohk-bors iohk-bors bot deleted the piotr/remove-shelley-cli-tx-tests-from-jorm branch September 25, 2020 08:46
This was referenced Oct 6, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees

@piotr-iohk piotr-iohk

Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @KtorZ