Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0116? | Universal JSON Encoding for Domain Types #766

Merged
merged 64 commits into from
May 14, 2024

Conversation

klntsky
Copy link
Contributor

@klntsky klntsky commented Feb 21, 2024

This is a CIP corresponding to CPS-11.

It includes a json-schema file specifying JSON layout for Babbage-era Cardano domain types.

The markdown file contains motivation for encoding choices and proposed conventions for building schemas for future eras.

(Rendered version)

@Ryun1 Ryun1 added Category: Wallets Proposals belonging to the 'Wallets' category. Category: Tools Proposals belonging to the 'Tools' category. and removed Category: Wallets Proposals belonging to the 'Wallets' category. labels Feb 21, 2024
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really great proposal 💪

See, my mainly housekeeping comments.

CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
CIP-XXXX/README.md Outdated Show resolved Hide resolved
@micahkendall
Copy link

Awesome

"format": "hex",
"pattern": "^[0-9a-f]{64}$",
"maxLength": 64,
"minLength": 64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we specify minLength for transaction hashes but not other things, such as keyHashes or addresses?

CIP-0116/cardano-babbage.json Outdated Show resolved Hide resolved
Co-authored-by: Vladimir Kalnitsky <[email protected]>
CIP-0116/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is is now a mature proposal, with lots of community technical review.
The author is now working on the Implementation Plan.
Great work 💪

Pre-meeting approval, ready for CIP editors meeting # 88.

@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label May 4, 2024
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise I am more than satisfied by the rounds of review & response: marked Last Check to keep attention on it until merging when fully ready (re: Implementation Plan).

@rphair rphair merged commit 3c0f51a into cardano-foundation:master May 14, 2024
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tools Proposals belonging to the 'Tools' category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants