-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPS-0011? | Universal JSON Encoding for Domain Types #742
Conversation
Co-authored-by: Ryan Williams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to promote at today's CIP meeting 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klntsky this looks fine from my level (not an implementor) and provides a good understanding of the problem. It passed @michaelpj's (edit: cursory) review (#742 (comment)) with only one change requested & done, so I have nothing further to add besides watching for consensus during further edits on the way to merging... great job with this 🚀
Would also like to see if & how this might relate to CIPs pending here:
Sorry, to be clear, I haven't reviewed this in detail. My comment was just a drive-by one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this to be a well written problem statement, happy to see it merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(operator error: redundant review)
One final comment from me (although raised by @Crypto2099) Have we considered the use of JSON-LD for this standard? |
We will keep this open for a couple more days ahead of the next wallets working group call |
@Ryun1 json-ld is not a schema language. See the original motivation for it: https://www.w3.org/DesignIssues/LinkedData.html For governance metadata it may be a good choice, but in this case there simply wouldn't be any documents to interlink. |
@Ryun1 are we punting this until next meeting (https://hackmd.io/@cip-editors/83) or do you feel we are ready to merge this now? |
We are good to merge 💪 |
Cardano domain types have canonical CDDL definitions (for every era), but when it comes to use in web apps, where JSON is the universally accepted format, there is no definite standard.
As a result, software solutions are incompatible with each other, and dApp developers are forced to write code for conversions that could in princible be unnecessary, because the semantics of different JSON layouts are often the same. In particular, this problem is very real when offchain libraries need to provide support for different query layer providers (examples: Lucid, Mesh.js, cardano-transaction-lib, Atlas).
The initiative to standardize query layers on Cardano is currently blocked due to absence of a standardized JSON data schema. However, such a schema would be useful in contexts other than query layers, which is the reason why this CPS is separate.
(proposal rendered from branch)