Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0082 | Improved Rewards Scheme Parameters #422

Conversation

TobiasFancee
Copy link
Contributor

@TobiasFancee TobiasFancee commented Jan 3, 2023

This is a new CIP for improving rewards scheme parameters. This proposal includes removing minPoolCost, adding minPoolRate, and increasing k. These are some of the most requested parameter changes discussed by the community. These changes will level the playing field for all stakepools while ensuring established community pools receive sufficient revenue via minPoolRate. This CIP does not deprecate CIP-0075 and is meant to be an alternative. While I still believe CIP-0075 to be useful, it simply makes too many changes to be implemented anytime soon (would require additional research). This CIP offers smaller changes that do not alter the incentives scheme. Rewards calculation for stakepools and pledge benefit are not changed (other than the addition of minPoolRate). In that way, I believe this CIP has a better chance of being implemented.

Forum Post:
https://forum.cardano.org/t/cip-improved-rewards-scheme-parameters/112409


(current proposal, rendered from branch)

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks; I read this one on the Cardano Forum already & in my opinion it's explicit and well-written except for the rank of the section headers.

I already wrote something about whether multiple CIPs should be submitted by the same author to accomplish the same thing (#387 (review)). I believe this is another one of those cases where the proposals should be merged, but also that this is a moot point without an engagement process from IOG for considering RSS change proposals.

These titles (including #421) are also more compelling without the subjective language. If there were a universal definition of "fair" or "improved" then original RSS mightn't have been disputable in the first place. I've tried to come up with objective alternatives but that's not easy either: "Decentralising" is hard to prove; perhaps "distributed" or "favouring distribution"?

CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
@TobiasFancee
Copy link
Contributor Author

I've made the suggested changes to the headers. Let me know if they are good now.

As for IOG considering RSS changes, I think we need to write the CIPs regardless. The community and SPOs need to be able to point to a CIP when asked about what they want.

As for subjective language, I agree that it is difficult to come up with better titles. An alternative might be "Updated Rewards Scheme Parameters" but that is quite generic. I actually think it's okay to have subjective titles in order to get community support. The community should understand it's a proposal and that they must form their own opinions. As for the title "Improved Rewards Scheme Parameters", I don't think it's that bad. This is an "Improvement Proposal" after all. If I did not consider it an improvement, I would not have posted it. Also, important to note CIP-0023 "Fair Min Fees" has a subjective title and it has been merged. Overall, I don't think the title is that bad, but I am open to suggestions for a new title.

Maybe a more objective title might be "Pledge Benefit Optimization" as this CIP makes pledge more important by removing minPoolCost and increasing k? But it doesn't change the pledge benefit, so I wouldn't want there to be confusion.

@rphair
Copy link
Collaborator

rphair commented Jan 5, 2023

@TobiasFancee: ... changes to the headers. Let me know if they are good now

Thanks: the header outline structure looks fine now 🤓

@rphair
Copy link
Collaborator

rphair commented Jan 14, 2023

Some notes for community consideration of this CIP have been made by the author here; most of this will already be known to RSS reviewers already but it is a pretty good review of this proposal's Rationale: https://twitter.com/TobiasFancee/status/1613949612766760960

@prometheus-pool
Copy link

I believe minPoolRate would be a huge improvement over minPoolCost for many of the reasons outlined in this CIP. At the same time I am not convinced a minPoolRate is necessary, and I believe it suffers from one of the major problems that minPoolCost suffers from, that it hides the most rewarding pools from delegators. Specifically, there will be pools that don't need to set any fixed cost because the minPoolRate covers their operating expenses and then some, and some of these pools would charge less than minPoolRate were they allowed to do so because they would still be profitable. Yet to delegators these pools will look the same as many other pools that are not being run as efficiently, meaning minPoolRate will make it difficult for delegators to select the best run pools. Such pools may rightfully feel frustrated that they are unable to leverage their competitive advantage to attract delegation, and the network may end up again paying people who are the loudest rather than the best at operating the network infrastructure.

An additional comment, I don't think it is necessarily true that "the pledge benefit on its own has no means to combat zero fee sybil pools" as you say in the CIP, it is certainly possible for a pool to leverage its pledge benefit to offer greater rewards than a 0 fee pool while still charging fees to cover its operating costs, how common this is comes down to the current parameter settings as well as the distribution of ada across the ecosystem. It seems like it would be valuable to test and adjust the protocol's researched parameters (after removing minPoolCost) before attempting to pre-empt potential problems by adding a new parameter such as minPoolRate to the protocol.

@rphair
Copy link
Collaborator

rphair commented Jan 17, 2023

Notes from CIP meeting today (cc @KtorZ)

#421 (comment) is also applicable here because the companies listed as Implementors ("Implementors include IOG, CF, and Emurgo") haven't agreed to implement or engage with this.

Also this would have to be merged as Inactive rather than Proposed because there's no framework for IOG to discuss or implement these proposals. It's been resolved at the meeting that we will have to do this for all RSS proposals, even ones that have already been merged.

@KtorZ KtorZ changed the title CIP-???? | Improved Rewards Scheme Parameters CIP-0082 | Improved Rewards Scheme Parameters Jan 17, 2023
@KtorZ KtorZ changed the title CIP-0082 | Improved Rewards Scheme Parameters CIP-0082? | Improved Rewards Scheme Parameters Jan 17, 2023
@TobiasFancee
Copy link
Contributor Author

So I guess these CIPs really are useless. At least they are educational. Let me know if there is anything else I need to do to get it merged.

@rphair
Copy link
Collaborator

rphair commented Jan 22, 2023

@TobiasFancee lots of people value your contributions and in my opinion all the RSS proposals support governance goals which have long term use beyond pure education.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is therefore ready to merge but based on prior discussion (I can dig up some links if needed) it should have a state of Inactive because there is no way to activate the RSS proposals.

The same would be true for #421 with the same modifications, and also fixing the header levels as for this one: #421 (review)

---
CIP: 82
Title: Improved Rewards Scheme Parameters
Status: Proposed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Status: Proposed
Status: Inactive (no IOG support)

... or some such "justification" which indicates the problem. @KtorZ we may need your help choosing a justification tag that will be (grimly) applied to all RSS proposals. Mentioning the specific company name seems undiplomatic but it is not inaccurate or open to interpretation either so I believe it should be stated baldly as such.

Copy link
Member

@KtorZ KtorZ Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd simply go for: "project area not enlisted for CIP process", which goes back to CIP-0001 and the need for a project to explicitly states their engagement to the CIP process.

CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
@TobiasFancee
Copy link
Contributor Author

@KtorZ @rphair I've removed any mention of entities with genesis keys and changed the status to "Project Area Not Enlisted for CIP Process" Let me know if this can be merged now or if further changes are necessary. Sorry I haven't been active in making these changes. I've had a busy month. My goal is to at least have this CIP ready for Voltaire.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the contrary @TobiasFancee I am happy you are following through with this. I would prefer to see this on the books during this period as well, but there are a couple more format nitpicks.

Also you will have to rename the project folder from CIP-Improved_Rewards_Scheme_Parameters to CIP-0082 before we merge it. 🤓

CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
CIP-Improved_Rewards_Scheme_Parameters/README.md Outdated Show resolved Hide resolved
@KtorZ KtorZ added the State: Likely Deprecated Close if confirmed deprecated (or long waiting). label Mar 18, 2023
@TobiasFancee
Copy link
Contributor Author

@KtorZ @rphair I've made the requested changes. Let me know if there is anything else needed to merge. Thanks.

@KtorZ KtorZ added State: Last Check Review favourable with disputes resolved; staged for merging. and removed State: Likely Deprecated Close if confirmed deprecated (or long waiting). labels Mar 18, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're welcome @TobiasFancee - this looks ready to merge at or before the next CIP meeting.

@KtorZ KtorZ merged commit 0f8fde9 into cardano-foundation:master Mar 20, 2023
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label May 2, 2023
@rphair rphair changed the title CIP-0082? | Improved Rewards Scheme Parameters CIP-0082 | Improved Rewards Scheme Parameters May 24, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
* Create README.md

* Add files via upload

* Update README.md

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Fix remaining headers.

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Matthias Benkort <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Change status to "Project Area Not Enlisted for CIP Process"

* Implementors: TBD

* Remove last mention of IOG from Path to Active

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Improved_Rewards_Scheme_Parameters/README.md

Co-authored-by: Robert Phair <[email protected]>

* Rename CIP-Improved_Rewards_Scheme_Parameters/README.md to CIP-0082/README.md

---------

Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Matthias Benkort <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants