Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0075 | Fair Stake Pool Rewards #421

Merged

Conversation

TobiasFancee
Copy link
Contributor

@TobiasFancee TobiasFancee commented Jan 3, 2023

New pull request for CIP-0075 because I renamed branch. I also made changes to meet new CIP-0001 requirements.


(rendered proposal in branch)

@rphair
Copy link
Collaborator

rphair commented Jan 4, 2023

Cross-referencing #422 (review) regarding subjective language in the proposal title.

@rphair rphair changed the title CIP-0075 | Fair Stakepool Rewards CIP-0075 | Fair Stake Pool Rewards Jan 16, 2023
@rphair
Copy link
Collaborator

rphair commented Jan 16, 2023

In my opinion the question of subjective language in title has been addressed in reply to the review comment above (in short, there aren't practical alternatives to this kind of language).

I've edited the title (also in the branch) because there is no such word as "Stakepool" ... not suggesting we do this in the entire document though; we just don't want high profile spelling errors to keep causing other spelling errors.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get all the Discussions: in as few places as possible, but with this CIP subject matter being split between this PR and #422 it's perhaps unavoidable that the discussion would also be split...

- Cardano Foundation
- Emurgo
Discussions:
- https://forum.cardano.org/t/cip-fair-stakepool-rewards/109368
Copy link
Collaborator

@rphair rphair Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the discussion on the Cardano Forum is fragmented, references to community discussions could also include this link itself and/or some of the ideas mentioned in this separate discussion thread: https://forum.cardano.org/t/cip-improved-rewards-scheme-parameters/112409

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. probably not the literal link itself, which is already in the preamble for #422.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TobiasFancee also just noticed this markdown has the same header rank problem we already fixed for your other CIP in #422 (review):

License: CC-BY-4.0
---

# Abstract
Copy link
Collaborator

@rphair rphair Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Abstract
# CIP-0075: Fair Stake Pool Rewards
## Abstract

... and likewise demoting the headers all the way down to a more web-friendly outline (in which pages only have one H1 and major sections are H2's) ...

Comment on lines 23 to 25
# Motivation

## Definitions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Motivation
## Definitions
## Motivation
### Definitions

... etc ...

**Sybil Attack**
- An attack on an online system where an entity tries to take over the network by creating many identities or nodes.

## The Current Rewards Equation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## The Current Rewards Equation
### The Current Rewards Equation

etc.

@prometheus-pool
Copy link

I think it would be great to mention in this CIP the trade off to removing the unsaturated pledge benefit penalty. Without this part of the reward sharing scheme it seems the protocol would no longer incentivize convergence to k pools since there is no benefit to consolidating stake to k pools if you can get the same rewards at another pool. There are advantages to converging to a specific number of pools such as ensuring that running network infrastructure remains economically viable and that the number of pools doesn't adversely effect network performance. The unsaturated pledge benefit penalty also still results in valuing pledge unlike minPoolCost, so it may perhaps be unfair to lump these both together as anticompetitive.

I think it would also be beneficial to discuss the trade off in reducing a0. It looks like there is currently around 1.3b in private pools earning close to maximum rewards via pledge benefit, but there is around 5x that amount being staked by 0 pledge CEX pools or auto staking wallets like adalite. Private pools make up around 5% of the total stake in the system and their additional rewards come from having skin in the game, while the other entities I've mentioned have 25% of the total stake in the system with 0 skin in the game. I think it is worth pausing to consider that reducing a0 will be giving a raise to these entities with no skin in the game when we actually probably want to give them reason to delegate the ada they control elsewhere, to people that do have skin in the game. Increasing k will also reduce the disparity between those earning maximum rewards now and those delegating to pools with high pledge, helping to mitigate the issue you point out without giving a raise to those with no pledge.

Implementors:
- Input Output Global
- Cardano Foundation
- Emurgo
Copy link
Member

@KtorZ KtorZ Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has any of those implementors agreed to be listed here? I hardly think so. As a reminder in CIP-0001:

Implementors must sign off on the plan and be referenced in the document's preamble.

Note also that implementors should preferably be individuals, not entities. Otherwise there's simply no accountability.

rphair

This comment was marked as outdated.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note at CIP meeting time)

---
CIP: 75
Title: Fair Stake Pool Rewards
Status: Proposed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following on last review it's become apparent at the CIP meeting today that this & all other RSS CIP's should only be merged with a status of Inactive (also noted in #422 (comment)).

@KtorZ KtorZ changed the title CIP-0075 | Fair Stake Pool Rewards CIP-0075? | Fair Stake Pool Rewards Jan 17, 2023
@TobiasFancee
Copy link
Contributor Author

@KtorZ @rphair I've fixed the headers and removed mention of entities with genesis keys. I've set status to "Project Area Not Enlisted for CIP Process" Let me know if this is okay or if "Inactive" would be preferred for status.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TobiasFancee this is proceeding in parallel with #422 so likewise I'm ready to approve this after a similar (probably final) round of format changes.

Also likewise, please rename the project folder from CIP-Fair_Stakepool_Rewards to CIP-0075 before we merge it. nerd_face

CIP-Fair_Stakepool_Rewards/README.md Outdated Show resolved Hide resolved
CIP-Fair_Stakepool_Rewards/README.md Outdated Show resolved Hide resolved
CIP-Fair_Stakepool_Rewards/README.md Outdated Show resolved Hide resolved
CIP-Fair_Stakepool_Rewards/README.md Outdated Show resolved Hide resolved
CIP-Fair_Stakepool_Rewards/README.md Outdated Show resolved Hide resolved
@KtorZ KtorZ added the State: Likely Deprecated Close if confirmed deprecated (or long waiting). label Mar 18, 2023
@TobiasFancee
Copy link
Contributor Author

@KtorZ @rphair I've made the requested changes. As with CIP-0082, let me know if there are any more changes needed to merge. Thank you guys for your help throughout this process.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're very welcome @TobiasFancee and as with parallel #422 I would say this is ready to merge at or before the next CIP meeting (@KtorZ therefore I'm also marking this one Last Check).

@rphair rphair added State: Last Check Review favourable with disputes resolved; staged for merging. and removed State: Likely Deprecated Close if confirmed deprecated (or long waiting). labels Mar 19, 2023
@rphair rphair requested a review from KtorZ March 19, 2023 13:34
@KtorZ KtorZ merged commit 9a95ec3 into cardano-foundation:master Mar 20, 2023
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label May 2, 2023
@rphair rphair changed the title CIP-0075? | Fair Stake Pool Rewards CIP-0075 | Fair Stake Pool Rewards May 24, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
* Create Fair Stake Pool Rewards CIP

* Add files via upload

* Add files via upload

* Update current viability point to 1 ADA

* Make changes for merge.

* Update README.md

* Update README.md

* spelling error in title - stake pool is 2 words

* Make changes required for merging.

* Remove last mention of IOG

* Update CIP-Fair_Stakepool_Rewards/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Fair_Stakepool_Rewards/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Fair_Stakepool_Rewards/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Fair_Stakepool_Rewards/README.md

Co-authored-by: Robert Phair <[email protected]>

* Update CIP-Fair_Stakepool_Rewards/README.md

Co-authored-by: Robert Phair <[email protected]>

* Rename CIP-Fair_Stakepool_Rewards/README.md to CIP-0075/README.md

---------

Co-authored-by: Robert Phair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants