Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds per-builtin instructions, removing BuiltinInst #4556

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Nov 19, 2024

Adds per-builtin instructions, removing BuiltinInst. This collapses builtin_inst_kind.def into inst_kind.def so that we have a single place for all macro uses. I still want to remove BuiltinInstKind, but it's something I think is better separated from the BuiltinInst removal.

I'm collapsing the build targets ids and inst_kind into one because they both have links to builtin kind information now. It's hard to separate without a cycle. I'm using the typed_insts name because that seems like the actual most significant thing there, and more interesting relative to the inst target.

@jonmeow
Copy link
Contributor Author

jonmeow commented Nov 19, 2024

Depends on #4555

@josh11b josh11b added this pull request to the merge queue Nov 21, 2024
Merged via the queue into carbon-language:trunk with commit 79b9180 Nov 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants