Adds per-builtin instructions, removing BuiltinInst
#4556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds per-builtin instructions, removing
BuiltinInst
. This collapsesbuiltin_inst_kind.def
intoinst_kind.def
so that we have a single place for all macro uses. I still want to removeBuiltinInstKind
, but it's something I think is better separated from theBuiltinInst
removal.I'm collapsing the build targets
ids
andinst_kind
into one because they both have links to builtin kind information now. It's hard to separate without a cycle. I'm using thetyped_insts
name because that seems like the actual most significant thing there, and more interesting relative to theinst
target.