Rename the builtin FloatType to LegacyFloatType, Error to ErrorInst #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
legacy-float-type
branch
2 times, most recently
from
35b209c
to
58ec234
Compare
jonmeow
changed the title
zygoloid
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for more clearly distinct names, and to make it a clearer transition from
BuiltinInstfor name conflicts.FloatTypeis also an instruction, and we haveCarbon::Error(common/error.h). This avoids affecting tests, although the name is embedded in the builtin test.In
LegacyFloatType,Legacybecause I was having trouble coming up with a more appropriate name. I'm not clear this is aFloatLiteralTypeat present, it needs some work to mirrorIntLiteralType.In
ErrorInst, the suffixInstwas discussed as good and similar toBuiltinInst(although I'm trying to get rid of that).