Suppress readability-enum-initial-value in clang-tidy #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @jonmeow |
This warns unhelpfully on enums like:
```
enum Kind: int8_t {
Value,
ValueOrRef,
...
FullInitializer,
Last = FullInitializer
};
```
It claims that all enum values should have explicit values if any of the
values do, but that's not what we would want to write here.
danakj
force-pushed
the
readability-enum-initial-value
branch
from
b57f9f7
to
f26e26d
Compare
jonmeow
reviewed
Nov 15, 2024
| -readability-function-cognitive-complexity, -readability-else-after-return, | ||
| -readability-identifier-length, -readability-implicit-bool-conversion, | ||
| -readability-magic-numbers, -readability-make-member-function-const, | ||
| -readability-else-after-return, -readability-enum-initial-value, |
There was a problem hiding this comment.
I've been trying to document why various warnings are disabled so that we don't forget. Can you add a note above, something like:
# - readability-enum-initial-value has false positives for `Last = ...`.
(it can't be here due to yaml parsing)
There was a problem hiding this comment.
Oh yes, thanks. I didn't notice the comments up there.
jonmeow
approved these changes
Nov 15, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warns unhelpfully on enums like:
It claims that all enum values should have explicit values if any of the
values do, but that's not what we would want to write here.