Suppress readability-redundant-member-init #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
reviewed
Nov 15, 2024
.clang-tidy
Outdated
| @@ -46,6 +46,7 @@ Checks: | |||
| -readability-function-cognitive-complexity, -readability-else-after-return, | |||
| -readability-identifier-length, -readability-implicit-bool-conversion, | |||
| -readability-magic-numbers, -readability-make-member-function-const, | |||
| -readability-redundant-member-init, | |||
There was a problem hiding this comment.
Similar to the other PR, to document why we're doing this, can you add a note above like:
# - readability-redundant-member-init hinders us from setting initializers to
# silence -Wmissing-designated-field-initializers.
There was a problem hiding this comment.
Yep, done and I rebased on top of #4540, so it should land first.
danakj
force-pushed
the
readability-redundant-member-init
branch
from
61fa456
to
0890154
Compare
auto-merge was automatically disabled
November 15, 2024 20:09
Head branch was pushed to by a user without write access
danakj
force-pushed
the
readability-redundant-member-init
branch
from
f451a8f
to
ba58f26
Compare
This initializes the DriverResult::per_file_success field explicitly
with `= {}` in order to encode that DriverResult can be constucted via
aggregate initialization while omitting the per_file_success field.
This prevents -Wmissing-designated-field-initializers from firing in
newer clang versions when constructing DriverResult like:
```
return {.success = false};
```
Newer clang-tidy warns that the `= {}` is redundant however it is not,
as its marking which fields need to be explicitly initialized. So we
suppress it.
auto-merge was automatically disabled
November 15, 2024 21:55
Head branch was pushed to by a user without write access
danakj
force-pushed
the
readability-redundant-member-init
branch
from
ba58f26
to
92f2e84
Compare
|
Rebased, PTAL |
|
bump, needs re-merge approval after rebase |
jonmeow
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initializes the DriverResult::per_file_success field explicitly with
= {}in order to encode that DriverResult can be constucted via aggregate initialization while omitting the per_file_success field. This prevents -Wmissing-designated-field-initializers from firing in newer clang versions when constructing DriverResult like:Newer clang-tidy warns that the
= {}is redundant however it is not, as its marking which fields need to be explicitly initialized. So we suppress it.