Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String literals #199

Merged
merged 27 commits into from
Mar 1, 2021
Merged

String literals #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
93991aa
Filling out template with PR 199
zygoloid Nov 25, 2020
7223ce0
First draft of String Literals proposal.
zygoloid Dec 2, 2020
a57ca75
Updates based on discussion with Chandler.
zygoloid Dec 9, 2020
46e657c
Apply suggestions from code review
zygoloid Jan 27, 2021
733c745
Respond to review comments. Major change: `\a`, `\b`, `\v`, `\f` no
zygoloid Jan 29, 2021
c5f74bb
Apply suggestions from code review
zygoloid Feb 3, 2021
1d22b7b
Move closing ``` to the right place.
zygoloid Feb 3, 2021
3f40a2e
Switch from Rust-style raw strings to Swift-stype raw strings.
zygoloid Feb 5, 2021
5453e2c
Add final newline to block string literals and allow it to be removed by
zygoloid Feb 5, 2021
809caa5
Fix typo.
zygoloid Feb 5, 2021
b72a98d
Fix example formatting.
zygoloid Feb 5, 2021
7ebeb36
Consistently use \<newline> not \<line feed>. We do want to allow
zygoloid Feb 5, 2021
f965bf1
Add missing terminating # from example.
zygoloid Feb 5, 2021
70fb976
Fix tense confusion.
zygoloid Feb 5, 2021
90e46ca
Support \""" in the middle of a block string literal.
zygoloid Feb 5, 2021
5431607
Explicitly say that we have no concatenation of adjacent string
zygoloid Feb 5, 2021
82f0b5d
Fix rendering of Java raw string literal with ` delimiters.
zygoloid Feb 5, 2021
19edc34
Make the Proposal section more explicit about what we mean by "most C
zygoloid Feb 5, 2021
0c9f175
Fixes from code review.
zygoloid Feb 5, 2021
ceffde0
Remove \uNNNN escape sequence based on core team discussion and
zygoloid Feb 10, 2021
9f122cd
Apply suggestions from code review
zygoloid Feb 10, 2021
fce62f3
Address review comments.
zygoloid Feb 11, 2021
68278a0
Distance Rust and Swift's \0 a little from octal escape sequences.
zygoloid Feb 11, 2021
492c7c5
Weaken recommentation for possible future directions. It's premature to
zygoloid Feb 11, 2021
0c281ba
Add brief rationale for choice of `#` rather than any other character
zygoloid Feb 11, 2021
e982db9
Apply suggestions from code review
zygoloid Feb 12, 2021
f1a6369
Rephrase \<newline> and \# descriptions to improve clarity and
zygoloid Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proposals/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,6 @@ request:
- [0175 - Decision](p0175_decision.md)
- [0179 - Create a toolchain team.](p0179.md)
- [0179 - Decision](p0179_decision.md)
- [0199 - String literals](p0199.md)

<!-- endproposals -->
Loading