Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String literals #199

Merged
merged 27 commits into from
Mar 1, 2021
Merged

String literals #199

merged 27 commits into from
Mar 1, 2021

Commits on Jan 27, 2021

  1. Filling out template with PR 199

    @zygoloid
    zygoloid committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    93991aa View commit details
    Browse the repository at this point in the history

  2. First draft of String Literals proposal.

    @zygoloid
    zygoloid committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    7223ce0 View commit details
    Browse the repository at this point in the history

  3. Updates based on discussion with Chandler.

    @zygoloid
    zygoloid committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    a57ca75 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jon Meow <[email protected]>
Co-authored-by: Chandler Carruth <[email protected]>
    @zygoloid @jonmeow @chandlerc
    3 people committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    46e657c View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Respond to review comments. Major change: \a, \b, \v, \f no 

    longer supported (following Rust and Swift).
    @zygoloid
    zygoloid committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    733c745 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c5f74bb View commit details
    Browse the repository at this point in the history

  2. Move closing ``` to the right place.

    @zygoloid
    zygoloid committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1d22b7b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Switch from Rust-style raw strings to Swift-stype raw strings.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3f40a2e View commit details
    Browse the repository at this point in the history

  2. Add final newline to block string literals and allow it to be removed by 

    a trailing \.
    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5453e2c View commit details
    Browse the repository at this point in the history

  3. Fix typo.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    809caa5 View commit details
    Browse the repository at this point in the history

  4. Fix example formatting.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    b72a98d View commit details
    Browse the repository at this point in the history

  5. Consistently use \<newline> not \<line feed>. We do want to allow 

    \<carriage return><line feed> here.
    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    7ebeb36 View commit details
    Browse the repository at this point in the history

  6. Add missing terminating # from example.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f965bf1 View commit details
    Browse the repository at this point in the history

  7. Fix tense confusion.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    70fb976 View commit details
    Browse the repository at this point in the history

  8. Support \""" in the middle of a block string literal.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    90e46ca View commit details
    Browse the repository at this point in the history

  9. Explicitly say that we have no concatenation of adjacent string 

    literals.
    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5431607 View commit details
    Browse the repository at this point in the history

  10. Fix rendering of Java raw string literal with ` delimiters.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    82f0b5d View commit details
    Browse the repository at this point in the history

  11. Make the Proposal section more explicit about what we mean by "most C 

    and C++ escape sequences".
    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    19edc34 View commit details
    Browse the repository at this point in the history

  12. Fixes from code review.

    @zygoloid
    zygoloid committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0c9f175 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Remove \uNNNN escape sequence based on core team discussion and 

    follow-up in open discussion slot.
    @zygoloid
    zygoloid committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ceffde0 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Dmitri Gribenko <[email protected]>
    @zygoloid @gribozavr
    zygoloid and gribozavr authored Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9f122cd View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Address review comments.

    @zygoloid
    zygoloid committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    fce62f3 View commit details
    Browse the repository at this point in the history

  2. Distance Rust and Swift's \0 a little from octal escape sequences.

    @zygoloid
    zygoloid committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    68278a0 View commit details
    Browse the repository at this point in the history

  3. Weaken recommentation for possible future directions. It's premature to 

    say exactly what constraints we'd want for guaranteed-valid-UTF-8 string
literals.
    @zygoloid
    zygoloid committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    492c7c5 View commit details
    Browse the repository at this point in the history

  4. Add brief rationale for choice of # rather than any other character 

    for raw strings.
    @zygoloid
    zygoloid committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    0c281ba View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Geoff Romer <[email protected]>
    @zygoloid @geoffromer
    zygoloid and geoffromer authored Feb 12, 2021
    Configuration menu
    Copy the full SHA
    e982db9 View commit details
    Browse the repository at this point in the history

  2. Rephrase \<newline> and \# descriptions to improve clarity and 

    precision. Define what a "non-empty content line" is rather than leaving
the reader to guess.

No change to the proposed direction is intended.
    @zygoloid
    zygoloid committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    f1a6369 View commit details
    Browse the repository at this point in the history