fix(writer): use WindowEventMap for cut/copy/paste events
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
typecheck-fixtures
branch
from
054d513 to
1539bcb
Compare
metonym
force-pushed
the
fix-window-event-map
branch
from
523a31d to
72ee05b
Compare
Merged
|
Fixed in v0.20.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
#92 added a workaround to map cut/copy/paste events as they previously did not exist on
WindowEventMap.Now that these are mapped in the
WindowEventMapinterface in TypeScriptlib.dom.d.tsdefinitions, fix this to avoid TS errors.