fix(writer): use WindowEventMap for cut/copy/paste events (#143)

Fixes #139
carbon-design-system · Oct 25, 2024 · cfe753f · cfe753f
1 parent 3826acb
commit cfe753f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/src/writer/writer-ts-definitions.ts b/src/writer/writer-ts-definitions.ts
@@ -124,11 +124,8 @@ function genSlotDef(def: Pick<ComponentDocApi, "slots">) {
     .join("\n");
 }
 
-const mapEvent = (name: string) => {
-  if (["cut", "copy", "paste"].includes(name)) {
-    return "DocumentAndElementEventHandlersEventMap";
-  }
-
+const mapEvent = () => {
+  // lib.dom.d.ts should map event types by name.
   return "WindowEventMap";
 };
 
@@ -147,7 +144,7 @@ function genEventDef(def: Pick<ComponentDocApi, "events">) {
         description = "/** " + event.description + " */\n";
       }
       return `${description}${clampKey(event.name)}: ${
-        event.type === "dispatched" ? createDispatchedEvent(event.detail) : `${mapEvent(event.name)}["${event.name}"]`
+        event.type === "dispatched" ? createDispatchedEvent(event.detail) : `${mapEvent()}["${event.name}"]`
       };\n`;
     })
     .join("");

diff --git a/tests/__snapshots__/fixtures.test.ts.snap b/tests/__snapshots__/fixtures.test.ts.snap
@@ -1553,11 +1553,7 @@ export interface InputEventsProps {}
 
 export default class InputEvents extends SvelteComponentTyped<
   InputEventsProps,
-  {
-    input: WindowEventMap["input"];
-    change: WindowEventMap["change"];
-    paste: DocumentAndElementEventHandlersEventMap["paste"];
-  },
+  { input: WindowEventMap["input"]; change: WindowEventMap["change"]; paste: WindowEventMap["paste"] },
   {}
 > {}
 "

diff --git a/tests/fixtures/input-events/output.d.ts b/tests/fixtures/input-events/output.d.ts
@@ -4,10 +4,6 @@ export interface InputEventsProps {}
 
 export default class InputEvents extends SvelteComponentTyped<
   InputEventsProps,
-  {
-    input: WindowEventMap["input"];
-    change: WindowEventMap["change"];
-    paste: DocumentAndElementEventHandlersEventMap["paste"];
-  },
+  { input: WindowEventMap["input"]; change: WindowEventMap["change"]; paste: WindowEventMap["paste"] },
   {}
 > {}