feat(CoachmarkStack): convert to .tsx #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
kennylam and
ariellalgilmore
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
makafsal
reviewed
May 22, 2024
packages/ibm-products/src/components/CoachmarkStack/CoachmarkStack.tsx
Outdated
Show resolved
Hide resolved
emyarod
force-pushed
the
4232-feat/CoachmarkStack-ts
branch
from
1a208ca to
88a49cc
Compare
makafsal
reviewed
Jun 6, 2024
| * | ||
| * @see {@link MEDIA_PROP_TYPE}. | ||
| */ | ||
| media: Media; |
There was a problem hiding this comment.
As per PropType media prop is optional.
| * | ||
| * @see {@link MEDIA_PROP_TYPE}. | ||
| */ | ||
| media: Media; |
emyarod
force-pushed
the
4232-feat/CoachmarkStack-ts
branch
from
88a49cc to
6479e5c
Compare
emyarod
force-pushed
the
4232-feat/CoachmarkStack-ts
branch
from
6479e5c to
bc261d9
Compare
makafsal
reviewed
Jun 21, 2024
| @@ -62,6 +139,24 @@ export let CoachmarkStackHome = forwardRef( | |||
| ); | |||
| } | |||
|
|
|||
| function renderNavLink(index, label, ref) { | |||
There was a problem hiding this comment.
In the previous code ref is optional ref = null, can you change it like that?
There was a problem hiding this comment.
it was already set to ref ?? null a few lines below but I've reverted the change
emyarod
force-pushed
the
4232-feat/CoachmarkStack-ts
branch
from
bc261d9 to
dfa8fa3
Compare
matthewgallo
approved these changes
Aug 5, 2024
davidmenendez
approved these changes
Aug 6, 2024
Merged
via the queue into
carbon-design-system:main
with commit Aug 6, 2024
ad6821c
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4491
Related #5097
This PR converts
CoachmarkStackandCoachmarkStackHometo TypeScriptWhat did you change?
How did you test and verify your work?
storybook build and type checks