feat(Coachmark): convert to .tsx #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
davidmenendez and
matthewgallo
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emyarod
force-pushed
the
5095-feat/Coachmark-ts
branch
from
1cfdcdc to
d91a9d1
Compare
Merged
via the queue into
carbon-design-system:main
with commit May 9, 2024
2c4d66f
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5095
This PR converts
Coachmarkto TypeScript. Will unblock #4494one thing to note is the hard coded drag handle string in
CoachmarkDragbar.tsx, this will need updating once our i18n strategy for strings is figured out.one other thing is the
overlayRefprop type declaration inCoachmark.tsx, it may need a second lookWhat did you change?
How did you test and verify your work?
storybook build and type checks