fix: adds aria label to datagrid toolbar #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| return ( | ||
| parseInt(key) !== | ||
| parseInt(getRowId(rowData.original, rowData.index)) | ||
| ); | ||
| }) |
There was a problem hiding this comment.
I'm not seeing any real changes. It looks like you saved this page, and it reformatted it for you.
Comment on lines
+27
to
+28
| const config = lens.filter((a) => typeof a === 'object')[0]; | ||
| const filteredData = lens.filter((a) => typeof a === 'number'); |
There was a problem hiding this comment.
I'm not seeing any real changes. It looks like you saved this page, and it reformatted it for you.
| return ( | ||
| <Datagrid | ||
| datagridState={{ ...datagridState }} | ||
| toolbarLabel="batch actions toolbar" |
There was a problem hiding this comment.
Just a nit. This "label" will never be visible to the user. Should it be renamed to something more self-descriptive, like "toolbarAriaLabel"?
There was a problem hiding this comment.
fair enough. fixt
paul-balchin-ibm
approved these changes
Feb 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 16, 2024
76cdfc6
13 checks passed
paul-balchin-ibm
pushed a commit
to paul-balchin-ibm/ibm-products
that referenced
this pull request
Feb 22, 2024
* fix: add aria label to datagrid toolbar * chore: format * fix: prop name change
paul-balchin-ibm
pushed a commit
to paul-balchin-ibm/ibm-products
that referenced
this pull request
Feb 26, 2024
* fix: add aria label to datagrid toolbar * chore: format * fix: prop name change
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
* feat: new component decorator * fix: code and styling updates * fix: udpate snapshots * fix: update gallery * fix: skip some tests (temp) * fix: minor changes * fix: updated PropTypes * fix: updated tests * fix: update styling * fix: updated snapshots and galleries * fix: storybook update * fix: update code, style, docs * fix: design review update * fix: design review update * fix: added a11y icon borders * fix: update icons and colors * fix: tests * fix: docs * fix: styling updates * fix: adds aria label to datagrid toolbar (#4348) * fix: add aria label to datagrid toolbar * chore: format * fix: prop name change * fix(Dataspreadsheet): Reduce duplication with isHoldingCommandKey #4188 (#4227) * feat(UserAvatar): implementation of name,size props (#4312) * feat(useravatar):implementation of name,size props * fix(useravatar): changed story name * fix(useravatar): review changes suggested * fix(useravatar): resolve test-c4p * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): name changes suggested --------- Co-authored-by: elysia <[email protected]> * feat: Tearsheet ai (#4215) * chore: wip * feat: tearsheet AI enhancements * feat: add gradient glow to container * chore(release): publish [skip ci] - [email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * chore: add new example gallery action (#4352) * chore: add new example gallery action * chore: remove gallery check from CI * chore: remove unused steps 🙃 * feat: Modal ai updates (#4362) * chore: wip * feat: tearsheet AI enhancements * feat: add gradient glow to container * chore: bump carbon versions * feat: modal ai v2 updates * fix: modal body * feat: modal ai v2 updates * Merge branch 'main' into modalAIUpdates * chore: update gallery config * fix(DataGrid): add support for selectrow and nestedrow (#4354) Co-authored-by: Matt Gallo <[email protected]> * feat(Datagrid): add support for multi select filter type (#4361) * chore: custom filter exploration continued * fix(DataGrid): add support for selectrow and nestedrow * chore: custom filter exploration * feat(Datagrid): add multi select option * chore: remove onClearFilters from prop types * chore: revert copyright year * chore: add multi select example to flyout * chore: revert nested/selection changes from branch * chore: update gallery config --------- Co-authored-by: Ratheesh Rajan <[email protected]> * feat(Datagrid): apply latest ai gradients to Datagrid (#4377) * fix(DataGrid): add support for selectrow and nestedrow * feat(Datagrid): apply latest ai gradients * chore: remove comments * chore: revert nested row changes pulled in accidentally * chore: update snapshot * chore: refactor how row class names are applied * fix: remove extra border --------- Co-authored-by: Ratheesh Rajan <[email protected]> * feat(useravatar): image implementation (#4355) * feat(useravatar):implementation of name,size props * fix(useravatar): changed story name * fix(useravatar): review changes suggested * fix(useravatar): resolve test-c4p * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): review changes suggested * fix(useravatar): name changes suggested * feat(useravatar): image implementation * fix(useravatar): resolve lint issue * fix(useravatar): resolve check-gallery * fix(useravatar): review changes suggested --------- Co-authored-by: elysia <[email protected]> * feat: sort icon appear in the Actions column on Datagrid #4339 (#4346) * chore(release): publish [skip ci] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * fix: move ai gradient to content (#4381) * chore(release): publish [skip ci] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * fix: merge conflicts * fix: update publish config in community package to public (#4383) * fix: header border issue introduced with ai slug (#4385) * chore(deps): bump ip to 2.0.1 (#4386) * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/UserAvatar Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/WebTerminal Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/TruncatedList Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/prefix-example Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip from 2.0.0 to 2.0.1 Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(APIKeyModal): add typescript types (#4336) * feat: beginning ts changes for APIKeyModal * chore: add custom typings to address broken types from carbon/react * fix: address remaining type issues * chore: refactor pw input import * chore: refactor customStep types * chore(deps): bump ip to 2.0.1 (#4401) * build(deps): bump ip in /examples/carbon-for-ibm-products/ProductiveCard Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/StatusIcon Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/SidePanel Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/TagSet Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/RemoveModal Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/PageHeader Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/Saving Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/Tearsheet Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump ip in /examples/carbon-for-ibm-products/SearchBar Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: new component status indicator (#4419) * fix: udpate gallery * fix: code review updates * fix: code review updates * chore: update chromedriver resolutions (#4422) * chore: add chromedriver to resolutions Fixes an issue with changed CDN * chore: remove from resolutions Keep latest chromedriver in yarn.lock * fix: tearsheet overlay (#4421) * fix: tearsheet overlay * fix: selector for old overlay --------- Co-authored-by: Matt Gallo <[email protected]> * fix: side panel slug and close position (#4426) * feat(Datagrid): add option to specify an initial sortable column (#4423) * feat(Datagrid): apply initial column sort functionality * fix: return if not using sortable table --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David Menendez <[email protected]> Co-authored-by: Amal K Joy <[email protected]> Co-authored-by: Anamika T S <[email protected]> Co-authored-by: elysia <[email protected]> Co-authored-by: Lee Chase <[email protected]> Co-authored-by: github-merge-queue <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ratheesh Rajan <[email protected]> Co-authored-by: Matt Gallo <[email protected]> Co-authored-by: SeonyuK <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4057