Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<a11y>Multiple "region" landmarks with the same parent region are not distinguished from one another because they have the same "data table toolbar" label #4057

Closed
1 task
xubinnb opened this issue Jan 16, 2024 · 3 comments · Fixed by #4378
Assignees

Comments

@xubinnb
Copy link

xubinnb commented Jan 16, 2024

===== ENVIRONMENT =====
Browser: Version 105.0.5195.125 (Official Build) (arm64)
Automatically update Chrome for all users Learn more
Test Tool Type: IBM Accessbility Checker

===== DEFECT DESCRIPTION =====

Problem 1: Multiple "region" landmarks with the same parent region are not distinguished from one another because they have the same "data table toolbar" label
Problem 2: Multiple elements with "region" role do not have unique labels

=====STEPS TO REPRODUCE =====
Go to https://dev.console.test.cloud.ibm.com/projects
Click 'Create'
Input the name and description to create a new project
Go to 'Management' tab
Go to 'Environment' tab
Click 'Add'

Use IBM Equal Access Accessibility Checker to scan

===== EXPECTED RESULT =====
IBM 1.3.1 Info and relationships
Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text.

IBM 2.4.1 Bypass Blocks
A mechanism is available to bypass blocks of content that are repeated on multiple Web pages.

===== SCREEN CAPTURE =====
image

Tasks

Preview Give feedback
@elycheea
Copy link
Contributor

elycheea commented Jan 18, 2024

@github-project-automation github-project-automation bot moved this from Needs triage 🧐 to Done 🚀 in Carbon for IBM Products Jan 18, 2024
@flannanl
Copy link

@elycheea We cannot set it. You render the TableToolbar component here: https://github.com/carbon-design-system/ibm-products/blob/main_v1/packages/ibm-products/src/components/Datagrid/Datagrid/DatagridToolbar.js#L191. Yes, the DataTableToolbar allows you to supply a custom aria-label, but you don't set it in your render and you don't have a way to allow us to pass you a label to set it there.

@xubinnb
Copy link
Author

xubinnb commented Jan 22, 2024

@elycheea Is this possible to reopen this issue? As I can not reopen in my side.

@elycheea elycheea reopened this Jan 22, 2024
@github-project-automation github-project-automation bot moved this from Done 🚀 to Needs triage 🧐 in Carbon for IBM Products Jan 22, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Jan 31, 2024
@elycheea elycheea moved this from Needs refinement 🤓 to Backlog 🌋 in Carbon for IBM Products Feb 1, 2024
@davidmenendez davidmenendez moved this from Backlog 🌋 to In progress in Carbon for IBM Products Feb 16, 2024
@elycheea elycheea moved this from In progress to Needs review 👋 in Carbon for IBM Products Feb 21, 2024
@elycheea elycheea moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Feb 21, 2024
@elycheea elycheea linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

4 participants