Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StatusIndicator): new component StatusIndicator #4327

Closed
wants to merge 38 commits into from
Closed

feat(StatusIndicator): new component StatusIndicator #4327

wants to merge 38 commits into from

Conversation

paul-balchin-ibm
Copy link
Contributor

@paul-balchin-ibm paul-balchin-ibm commented Feb 13, 2024 •
edited
Loading

Contributes to #4071

Migrating StatusIndicator from Products v1 / Patterns / StatusIndicator.

v1 references: GitHub, Storybook.

What did you change?

This is a new v2 component.

StatusIndicator prop updates

Old prop New prop Change
title title Unchanged.
— onRetry Optional callback function.
— retryLabel Text label for the retry button.
— showRetry
currentIndex (deprecated)
retry: {action, label} (deprecated) Replaced by onRetry and retryLabel above

StatusIndicatorStep prop updates (name changed from StatusStep).

Old prop New prop Change
description description No change.
incomplete inactive *
current active *
failed error *
complete finished *
errorMsg errorMessage

* The new names are in keeping with the InlineLoading component.

How did you test and verify your work?

  • Storybook review.
  • Design update by Cameron Calder and Bridget Ndege.
  • Design review by Shelly Dignum.

@paul-balchin-ibm paul-balchin-ibm requested a review from a team as a code owner February 13, 2024 18:40
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9d8cdbd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/65d76645603e310008f0f517
😎 Deploy Preview https://deploy-preview-4327--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paul-balchin-ibm paul-balchin-ibm marked this pull request as draft February 13, 2024 18:40
@paul-balchin-ibm paul-balchin-ibm self-assigned this Feb 13, 2024
@paul-balchin-ibm paul-balchin-ibm added package: security version: 2 Carbon 11 / v2 area: migration ➡️ Migration of Security package to IBM Products labels Feb 13, 2024
@paul-balchin-ibm paul-balchin-ibm linked an issue Feb 13, 2024 that may be closed by this pull request
New Component: : StatusIndicator #4253
Closed
4 tasks
@paul-balchin-ibm paul-balchin-ibm marked this pull request as ready for review February 16, 2024 20:05
matthewgallo
matthewgallo reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the composable approach 😄 just had a few small comments/suggestions

davidmenendez and others added 25 commits February 22, 2024 10:00
@davidmenendez @paul-balchin-ibm
fix: adds aria label to datagrid toolbar (carbon-design-system#4348)
ef74e79 
* fix: add aria label to datagrid toolbar

* chore: format

* fix: prop name change
@amal-k-joy @paul-balchin-ibm
fix(Dataspreadsheet): Reduce duplication with isHoldingCommandKey car…
4a3632a 
…bon-design-system#4188 (carbon-design-system#4227)
@anamikaanu96 @elycheea @paul-balchin-ibm
feat(UserAvatar): implementation of name,size props (carbon-design-sy…
9d9588a 
…stem#4312)

* feat(useravatar):implementation of name,size props

* fix(useravatar): changed story name

* fix(useravatar): review changes suggested

* fix(useravatar): resolve test-c4p

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): name changes suggested

---------

Co-authored-by: elysia <[email protected]>
@lee-chase @paul-balchin-ibm
feat: Tearsheet ai (carbon-design-system#4215)
818ccf9 
* chore: wip

* feat: tearsheet AI enhancements

* feat: add gradient glow to container
@github-actions @paul-balchin-ibm
chore(release): publish [skip ci]
eae9209 
 - [email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
@elycheea @paul-balchin-ibm
chore: add new example gallery action (carbon-design-system#4352)
1660c9e 
* chore: add new example gallery action

* chore: remove gallery check from CI

* chore: remove unused steps

🙃
@paul-balchin-ibm
fix: merge conflicts
ebec924
@Ratheeshrajan @matthewgallo @paul-balchin-ibm
fix(DataGrid): add support for selectrow and nestedrow (carbon-design…
78d5fd0 
…-system#4354)

Co-authored-by: Matt Gallo <[email protected]>
@matthewgallo @Ratheeshrajan @paul-balchin-ibm
feat(Datagrid): add support for multi select filter type (carbon-desi…
89812e8 
…gn-system#4361)

* chore: custom filter exploration continued

* fix(DataGrid): add support for selectrow and nestedrow

* chore: custom filter exploration

* feat(Datagrid): add multi select option

* chore: remove onClearFilters from prop types

* chore: revert copyright year

* chore: add multi select example to flyout

* chore: revert nested/selection changes from branch

* chore: update gallery config

---------

Co-authored-by: Ratheesh Rajan <[email protected]>
@matthewgallo @Ratheeshrajan @paul-balchin-ibm
feat(Datagrid): apply latest ai gradients to Datagrid (carbon-design-…
3ef7eb2 
…system#4377)

* fix(DataGrid): add support for selectrow and nestedrow

* feat(Datagrid): apply latest ai gradients

* chore: remove comments

* chore: revert nested row changes pulled in accidentally

* chore: update snapshot

* chore: refactor how row class names are applied

* fix: remove extra border

---------

Co-authored-by: Ratheesh Rajan <[email protected]>
@paul-balchin-ibm
Revert "fix: simplified stories"
aba876b 
This reverts commit 2eed412632d489baf3db60c13eb5c3c7f332389e.
@paul-balchin-ibm
fix: review updates
1aec848
@anamikaanu96 @elycheea @paul-balchin-ibm
feat(useravatar): image implementation (carbon-design-system#4355)
2481922 
* feat(useravatar):implementation of name,size props

* fix(useravatar): changed story name

* fix(useravatar): review changes suggested

* fix(useravatar): resolve test-c4p

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): review changes suggested

* fix(useravatar): name changes suggested

* feat(useravatar): image implementation

* fix(useravatar): resolve lint issue

* fix(useravatar): resolve check-gallery

* fix(useravatar): review changes suggested

---------

Co-authored-by: elysia <[email protected]>
@SeonyuK @paul-balchin-ibm
feat: sort icon appear in the Actions column on Datagrid carbon-desig…
710c4c1 
…n-system#4339 (carbon-design-system#4346)
@github-actions @paul-balchin-ibm
chore(release): publish [skip ci]
c82eb98 
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
@lee-chase @paul-balchin-ibm
fix: move ai gradient to content (carbon-design-system#4381)
7954fae
@github-actions @paul-balchin-ibm
chore(release): publish [skip ci]
f45511c 
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
@paul-balchin-ibm
fix: merge conflicts
572b309
@davidmenendez @paul-balchin-ibm
fix: update publish config in community package to public (carbon-des…
2ef676c 
…ign-system#4383)
@lee-chase @paul-balchin-ibm
fix: header border issue introduced with ai slug (carbon-design-syste…
5985320 
…m#4385)
@elycheea @dependabot @paul-balchin-ibm
chore(deps): bump ip to 2.0.1 (carbon-design-system#4386)
039f5d4 
* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip in /examples/carbon-for-ibm-products/UserAvatar

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip in /examples/carbon-for-ibm-products/WebTerminal

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip in /examples/carbon-for-ibm-products/TruncatedList

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip in /examples/carbon-for-ibm-products/prefix-example

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip from 2.0.0 to 2.0.1

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump ip

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@matthewgallo @paul-balchin-ibm
feat(APIKeyModal): add typescript types (carbon-design-system#4336)
e50d09b 
* feat: beginning ts changes for APIKeyModal

* chore: add custom typings to address broken types from carbon/react

* fix: address remaining type issues

* chore: refactor pw input import

* chore: refactor customStep types
@paul-balchin-ibm
Merge branch 'main' into feat-4253_new-component-status-indicator-2
ba4dfab
@paul-balchin-ibm
Merge branch 'main' into feat-4253_new-component-status-indicator-2
b1da1dc
@paul-balchin-ibm
fix: snapshot and gallery updates
9d8cdbd
@paul-balchin-ibm paul-balchin-ibm marked this pull request as draft February 22, 2024 15:55
@paul-balchin-ibm paul-balchin-ibm mentioned this pull request Feb 22, 2024
Merged
3 tasks
@matthewgallo
Copy link
Member

Closing in favor of #4419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewgallo matthewgallo matthewgallo approved these changes

Assignees

@paul-balchin-ibm paul-balchin-ibm

Labels
area: migration ➡️ Migration of Security package to IBM Products package: security status: waiting for author 💬 version: 2 Carbon 11 / v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Component: : StatusIndicator
9 participants
@paul-balchin-ibm @matthewgallo @elycheea @davidmenendez @amal-k-joy @anamikaanu96 @lee-chase @Ratheeshrajan @SeonyuK