feat(TruncatedList): new component TruncatedList #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
elycheea
added
the
area: migration ➡️
matthewgallo
reviewed
Feb 6, 2024
| <ListItem>Item 5</ListItem> | ||
| </TruncatedList> | ||
| ); | ||
| expect(document.querySelectorAll(`li`).length).toBe(2); |
There was a problem hiding this comment.
Use getByRole here to avoid using document.querySelector.
Possibly something like the follow:
expect(screen.getByRole('listitem').length).toBe(2);
matthewgallo
reviewed
Feb 6, 2024
| <ListItem>Item 2</ListItem> | ||
| </TruncatedList> | ||
| ); | ||
| expect(document.querySelector(`.${blockClass}`)).toHaveClass(className); |
There was a problem hiding this comment.
Use data-testid here to avoid document.querySelector.
matthewgallo
reviewed
Feb 6, 2024
| <ListItem>Item 2</ListItem> | ||
| </TruncatedList> | ||
| ); | ||
| expect(document.querySelector(`.${blockClass}`)).toBeInTheDocument(); |
There was a problem hiding this comment.
Use data-testid here to avoid document.querySelector.
matthewgallo
previously approved these changes
Feb 6, 2024
matthewgallo
approved these changes
Feb 6, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 6, 2024
bc54d2f
13 checks passed
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4071
Migrating TruncatedList from
Products v1 / Security / TruncatedList.v1references: GitHub, Storybook.What did you change?
This is a new
v2component.Prop updates
getExpandButtonLabelviewLessLabelandviewMoreLabel.truncateThresholdscrollGradientColorHow did you test and verify your work?