Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar #4149

Closed
1 task done
Tracked by #4611
elycheea opened this issue Jan 24, 2024 · 0 comments
Closed
1 task done
Tracked by #4611

Search bar #4149

elycheea opened this issue Jan 24, 2024 · 0 comments
Assignees
Labels
area: migration ➡️ Migration of Security package to IBM Products package: security version: 2 Carbon 11 / v2

Comments

@elycheea
Copy link
Contributor

elycheea commented Jan 24, 2024

Search bar

Brief description

This component is to be migrated from the @carbon/ibm-security package (found in main_v1 packages/security) to our main branch and is part of the initiative documented in #4052 and #4036.

Migrate SearchBar from Products v1 / Security / TruncatedList to Products v2.

References: GitHub, Storybook.

Details

Link to Security version

Notes on this migration
For this initial release, we will follow these two principles to keep working moving forward and to unblock teams reliant on the older package —

  1. Zero design changes from Security to Products. This make it easier to compare old component to new component. Any design updates can as followup.
  2. New components must meet Products’ code specs. Rather than copy and paste old code from Security to Products, we will refactor it to ensure they’re up to date.

Summary from @paul-balchin-ibm’s initial review —

SearchBar

GitHub, Storybook

TLDR

  • See This component must be refactored from a Class to a Function. (Link)

PROBLEMATIC IMPORTS

import Button from '../Button';
import Search from '../Search';
import MultiSelect from '../MultiSelect';

Links to other materials

  • The level of work required for all components

Design contacts

Tasks

Before starting work on this epic, please review and complete the following.

Working in Carbon for IBM Products package

Acceptance criteria

Preview Give feedback
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jan 24, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Jan 24, 2024
@elycheea elycheea added area: migration ➡️ Migration of Security package to IBM Products package: security and removed package: security labels Jan 24, 2024
@elycheea elycheea moved this from Needs refinement 🤓 to Backlog 🌋 in Carbon for IBM Products Jan 24, 2024
@makafsal makafsal moved this from Backlog 🌋 to In progress in Carbon for IBM Products Jan 25, 2024
@makafsal makafsal moved this from In progress to Needs review 👋 in Carbon for IBM Products Feb 5, 2024
@elycheea elycheea closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Feb 5, 2024
@elycheea elycheea reopened this Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Done 🚀 to Needs triage 🧐 in Carbon for IBM Products Feb 5, 2024
@elycheea elycheea moved this from Needs triage 🧐 to In review 👀 in Carbon for IBM Products Feb 7, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🚀 in Carbon for IBM Products Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: migration ➡️ Migration of Security package to IBM Products package: security version: 2 Carbon 11 / v2
Projects
Archived in project
Development

No branches or pull requests

2 participants