Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security PAL Migration #4611

Closed
19 of 36 tasks
sstrubberg opened this issue Mar 26, 2024 · 4 comments
Closed
19 of 36 tasks

Security PAL Migration #4611

sstrubberg opened this issue Mar 26, 2024 · 4 comments
Labels
Milestone

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Mar 26, 2024

As a developer consuming components and patterns from the deprecated Security PAL, I can confidently find these assets, refactored with modern coding standards and updated to use v11 tokens in the Product PAL storybook.

As a designer consuming components and patterns from the deprecated Security PAL, I can confidently find these assets in the Figma kit.

As a designer and developer, consuming components and patterns from the deprecated Security PAL, I can confidently find information on how to use these assets documented on the Product PAL website.

Refer to internal design issue
https://github.ibm.com/CDAI-design/pal/issues/1203

Tasks

Preview Give feedback
  1. area: migration ➡️ package: ibm-products package: security
    paul-balchin-ibm
  2. area: migration ➡️ package: security
    paul-balchin-ibm
  3. area: migration ➡️ package: security
    paul-balchin-ibm
  4. area: migration ➡️ package: security
    paul-balchin-ibm
  5. 3 of 3
    area: migration ➡️ package: ibm-products
    devadula-nandan
  6. area: migration ➡️
    paul-balchin-ibm
  7. area: migration ➡️ package: security version: 2
    paul-balchin-ibm
  8. 0 of 2
    area: migration ➡️
    paul-balchin-ibm
  9. area: migration ➡️ package: security status: waiting for maintainer 💬 version: 2
    jlongshore
  10. area: migration ➡️ package: security status: waiting for maintainer 💬 version: 2
    jlongshore
  11. 1 of 1
    area: migration ➡️ package: security version: 2
    makafsal
  12. 0 of 2
    area: migration ➡️ role: dev
    IgnacioBecerra
  13. area: migration ➡️
    elycheea
  14. area: migration ➡️ package: security version: 2
    paul-balchin-ibm
  15. area: migration ➡️ package: security
    lily-peng
  16. area: migration ➡️ package: security version: 2
    paul-balchin-ibm
  17. area: migration ➡️ package: security status: waiting for maintainer 💬 version: 2
    jlongshore
  18. area: migration ➡️ package: security version: 2
    paul-balchin-ibm
  19. area: migration ➡️
    jlongshore
  20. 6 of 6
    area: migration ➡️
    paul-balchin-ibm
  21. area: migration ➡️ type: docs 📖
    jlongshore paul-balchin-ibm
@sstrubberg sstrubberg added this to the 2024 Q2 milestone Mar 26, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Mar 26, 2024
@sstrubberg sstrubberg moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Mar 26, 2024
@sstrubberg
Copy link
Member Author

sstrubberg commented Apr 2, 2024

  • The Decorator can have icons in it. It also has interactive elements. Strong experimental InteractiveTag vibes from Core.
  • The Decorator has a lot of color stuff going on (@oliviaflory). It also has this key pair interaction moment that is different than Core's.
  • BigNumbers feels pretty straightforward
  • DescriptionList: Is this a thing? It's StructuredList under the hood. Should we just deprecate it?
  • Action was internal. Now it's not. And it's supplanting IconButtonBar because it "does everything plus more" - Paul
  • Nav is open to question. Is this a thing? It feels a lot like ContainedList from Core.
  • StringFormatter and DelimitedList feel like utilities, not components.

@elycheea
Copy link
Contributor

elycheea commented Apr 2, 2024

@sstrubberg We should probably have a high level conversation about next steps so we’re aligned with Security team on what to expect coming up.

  • Decorator, big numbers (ICA), description list, search bar, scroll gradient, action bar (icon button bar) are the ones we’ve seen listed as priorities in the design repo.
  • String formatter, possibly nav and filters are ease of migration from what I can recall from previous conversations. 👀

@elycheea
Copy link
Contributor

elycheea commented Apr 3, 2024

Based on our call on April 3, 2024.

Proposals

These are items we want to push forward and expand for broader use case outside of Security.

  • Decorator probably a good proposal to contribute further.
  • ICA / big numbers also worth a proposal too.
  • Filter panel brought it over to help teams for migration but likely will become foundation for broader filtering experience. Expect to have changes as we broaden it for overall IBM Software. Needs design attention.
  • Status indicator seems like a decent proposal. Helpful for multi-sequenced events like this.
  • Action bar probably a proposal.
  • Search bar as a proposal.

Utilities

These are written as components but are probably more of utilities. Would be good to explore what this should look like longer term. Think there’s some precedent of utilities both as hooks and components in Carbon as well (Theme, useTheme(), Layer, useLayer()).

  • Delimited list feels more like a utility ... might make more sense to recategorize (might change for stable).
  • String formatter another utility ... possible re-categorization.
  • Truncated list pretty useful for the functionality but possibly more utilitarian. Probably needs more thought if on how we categorize it.
  • Scroll gradient also more of a utility.

Migration-path only

These should probably be deprecated over time but we’ve included it to ease the migration effort.

  • Nav — No strong opinions ... probably migration path. Probably deprecate over time — similar to accordion. Recommend teams to migrate to Accordion over time.

Other

Description list likely should become a structured list variant.
DescriptionListModule that references this has another variant that has key value pairs stacked.

@sstrubberg sstrubberg removed this from the 2024 Q2 milestone Apr 29, 2024
@ljcarot ljcarot added this to the 2024 Q2 milestone Jun 26, 2024
@matthewgallo matthewgallo moved this from Needs refinement 🤓 to Later 🏔️ in Carbon for IBM Products Jun 26, 2024
@matthewgallo
Copy link
Member

We'll open up follow up issues for any further work here, initial components in migration have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants