Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up SearchBar props #4602

Closed
2 tasks
Tracked by #4611
elycheea opened this issue Mar 25, 2024 · 2 comments
Closed
2 tasks
Tracked by #4611

Clean up SearchBar props #4602

elycheea opened this issue Mar 25, 2024 · 2 comments
Assignees
Labels
area: migration ➡️ Migration of Security package to IBM Products role: dev
Milestone

Comments

@elycheea
Copy link
Contributor

elycheea commented Mar 25, 2024

FYI, noticing that several of the props, (scopesTypeLabel, scopes, selectedScopes, translateWithId, sortItems) are meant to be passed to the MultiSelect. Since these are all related, I wonder if it would make sense to follow the approach from @davidmenendez where we have Dropdown in AddSelect and we group these related props in an object/array.

yeah i agree with this. basically any time that we're working with multiple carbon components we should do our best to enable users to pass as many props to those components for maximum flexibility. unless there's a specific callout in the design to not use something specific we should probably have something like btnProps = {} and multiSelectProps = {}

Originally posted by @davidmenendez in #4239

Acceptance criteria

Preview Give feedback
@elycheea elycheea added the area: migration ➡️ Migration of Security package to IBM Products label Mar 25, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Mar 25, 2024
@elycheea
Copy link
Contributor Author

@jlongshore Do we want to add more migration detail in Box or include details directly in #4437

@sstrubberg sstrubberg moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Mar 27, 2024
@sstrubberg sstrubberg moved this from Backlog 🌋 to Needs refinement 🤓 in Carbon for IBM Products Mar 27, 2024
@sstrubberg sstrubberg added this to the 2024 Q2 milestone Mar 27, 2024
@sstrubberg sstrubberg moved this from Needs refinement 🤓 to Backlog 🌋 in Carbon for IBM Products Mar 27, 2024
@IgnacioBecerra IgnacioBecerra moved this from Backlog 🌋 to In progress in Carbon for IBM Products Apr 4, 2024
@jlongshore
Copy link
Contributor

jlongshore commented Apr 18, 2024

@jlongshore Do we want to add more migration detail in Box or include details directly in #4437

Yeah If you like you can do your work in the Box note and I can update the migration doc from it...
Reviewed the changes, I believe this is everything that a user would care about
image

@IgnacioBecerra IgnacioBecerra moved this from In progress to Needs review 👋 in Carbon for IBM Products May 3, 2024
@IgnacioBecerra IgnacioBecerra moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products May 13, 2024
@IgnacioBecerra IgnacioBecerra closed this as completed by moving to Done 🚀 in Carbon for IBM Products May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: migration ➡️ Migration of Security package to IBM Products role: dev
Projects
Archived in project
Development

No branches or pull requests

4 participants