-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Pagination): add support for sizes #9215
feat(Pagination): add support for sizes #9215
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 80b4205 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610ab56a72053f0007bfc2c4 😎 Browse the preview: https://deploy-preview-9215--carbon-react-next.netlify.app |
❌ Deploy Preview for carbon-elements failed. 🔨 Explore the source changes: 80b4205 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610ab56ac077920008b45ddc |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 80b4205 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610ab56ac077920008b45dde 😎 Browse the preview: https://deploy-preview-9215--carbon-components-react.netlify.app |
cc @jeanservaas when you have a chance to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5a8eaa6
to
acda18b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aagonzales just pushed up a change to square the buttons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
related #8875
This PR adds support for Pagination component sizes and sets up the groundwork for scaling with data table sizes
Changelog
New
size
prop in PaginationTesting / Reviewing
Confirm the pagination sizes (configurable with storybook knob) appear correct