Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): add support for sizes #9215

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 16, 2021

related #8875

This PR adds support for Pagination component sizes and sets up the groundwork for scaling with data table sizes

Changelog

New

  • size prop in Pagination

Testing / Reviewing

Confirm the pagination sizes (configurable with storybook knob) appear correct

@netlify
Copy link

netlify bot commented Jul 16, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 80b4205

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610ab56a72053f0007bfc2c4

😎 Browse the preview: https://deploy-preview-9215--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 16, 2021

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: 80b4205

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610ab56ac077920008b45ddc

@netlify
Copy link

netlify bot commented Jul 16, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 80b4205

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610ab56ac077920008b45dde

😎 Browse the preview: https://deploy-preview-9215--carbon-components-react.netlify.app

@tw15egan
Copy link
Collaborator

cc @jeanservaas when you have a chance to review

@emyarod emyarod requested a review from a team July 22, 2021 16:54
@emyarod emyarod mentioned this pull request Jul 26, 2021
62 tasks
@joshblack joshblack requested review from aagonzales and removed request for jeanservaas July 29, 2021 16:37
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the select background come in as the wrong color.

image

@emyarod
Copy link
Member Author

emyarod commented Jul 29, 2021

is that an issue with the netlify previews or is it also present in local builds? this PR only adds more size options to the component

image

image

image

@emyarod emyarod force-pushed the add-pagination-sizes branch from 5a8eaa6 to acda18b Compare August 2, 2021 14:26
@tw15egan tw15egan requested a review from aagonzales August 3, 2021 15:06
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really see a design spec for this but I think the previous/next page buttons need to be squared up in width.

image

@tw15egan
Copy link
Collaborator

tw15egan commented Aug 3, 2021

@aagonzales just pushed up a change to square the buttons

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 06216df into carbon-design-system:main Aug 4, 2021
@emyarod emyarod deleted the add-pagination-sizes branch August 4, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants