Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide data table toolbar heights to match new row heights #8875

Closed
Tracked by #9123
vsnichols opened this issue Jun 9, 2021 · 2 comments
Closed
Tracked by #9123

Provide data table toolbar heights to match new row heights #8875

vsnichols opened this issue Jun 9, 2021 · 2 comments
Labels
component: data-table package: react carbon-components-react proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. proposal: open This request has gone through triaging. We're determining whether we take this on or not. severity: 3 https://ibm.biz/carbon-severity type: enhancement 💡

Comments

@vsnichols
Copy link

Summary

The Cloud & Cognitive data table workstream is requesting additional data table toolbar heights in order to match the available row heights.

Currently there are 4 possible row heights for data tables (with a 5th height coming in Carbon 11):

  • Compact 24px
  • Short 32px
  • Default 48px
  • Tall 64px

However there are only two toolbar heights, 32px and 48px. The majority of row heights will have to be paired with a clashing toolbar. We are asking for development support to add additional toolbar heights, so that the toolbar height always matches the row height.

As-Is: 24px row height with 32px toolbar and 48px pagination bar

image

Proposed: All components are 24px

image

Note: this issue is not as high a priority as Provide pagination bar heights to match new data table row heights #8874. For MVP we could just add a 32px pagination height. The compact toolbar size (24px) is tricky as Carbon does not currently offer 24px search or buttons.

MVP option: 24px row height with 32px toolbar and 48px pagination bar

image

Justification

  • We are rolling out the table settings feature more widely, which means that these alternative heights will begin to be more heavily used, and the visual inconsistencies will become more obvious.

  • Today, if a user switches to the 24px row height, their pagination will still be 48px, and their toolbar will be 32px. It would be nice to have consistency across these elements.

Screen Shot 2021-06-09 at 6 13 45 PM

Desired UX and success metrics

If a user switches row height, the table toolbar would switch to matching height.

"Must have" functionality

N/A

Specific timeline issues / requests

Ideally it would be great to roll this out with Carbon 11 as we introduce the new row heights. We would love to roll this update into the data table settings feature being worked on by the Cloud & Cognitive data table workstream.

Available extra resources

We can provide design support and potentially some dev support.

@emyarod
Copy link
Member

emyarod commented Jul 12, 2021

cc @carbon-design-system/design just to confirm, do we want the table toolbars to match the table row sizes or are they fine the way they currently scale with the rows?

@jeanservaas
Copy link
Collaborator

jeanservaas commented Jul 15, 2021

I don't really see a problem with continuing to use the 32px toolbar with data tables that have 24px rows, especially since we don't offer those components at 24px.

Since there’s a lot of functionality in the toolbar, I really think the emphasis is OK. I have no problem with introducing a 24px pagination. Thought to me, this also seems like a good option.

image

@jnm2377 jnm2377 added proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed impact: high 😱 labels Feb 2, 2022
@tay1orjones tay1orjones moved this to Not pursuing in Roadmap Aug 24, 2022
@sstrubberg sstrubberg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data-table package: react carbon-components-react proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. proposal: open This request has gone through triaging. We're determining whether we take this on or not. severity: 3 https://ibm.biz/carbon-severity type: enhancement 💡
Projects
Archived in project
Development

No branches or pull requests

6 participants