-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@carbon/styles): remove / operator, use math.div #9078
fix(@carbon/styles): remove / operator, use math.div #9078
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: b4a51da 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61095a8452268000071a6604 😎 Browse the preview: https://deploy-preview-9078--carbon-react-next.netlify.app/ |
❌ Deploy Preview for carbon-elements failed. 🔨 Explore the source changes: b4a51da 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61095a84deba790007d28a32 |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: b4a51da 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61095a84e0c32700087cde96 😎 Browse the preview: https://deploy-preview-9078--carbon-components-react.netlify.app/ |
@joshblack seems like this is causing all the tests to fail in |
@tw15egan hmm, if it's using As a side-note, would it make sense to start with these changes over in This would end up helping out teams who are making the move to dart sass now so they don't have to see warnings in their console all over the place. |
It looks like there are only a few places where we use the |
d5525d9
to
2308ca3
Compare
Closes #8746
WIP, will update as more components are added to the
@carbon/styles
packageChangelog
Changed
/
symbol with themath.div
function or*
where possibleTesting / Reviewing
Ensure styles remain the same with the changes and no deprecation warnings are thrown