Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of / operator to use math.div #8746

Closed
Tracked by #8966
joshblack opened this issue May 24, 2021 · 3 comments · Fixed by #9508
Closed
Tracked by #8966

Update usage of / operator to use math.div #8746

joshblack opened this issue May 24, 2021 · 3 comments · Fixed by #9508
Assignees

Comments

@joshblack
Copy link
Contributor

The / operator will be deprecated in Dart Sass 2.0.0 as pointed out in: #8069 (comment)

This issue tracks the updates needed in @carbon/styles to move away from the / operator to math.div as has been recommended in: https://sass-lang.com/documentation/breaking-changes/slash-div

Unfortunately, our current Sass targets include node-sass and I don't believe this is something we can address in our codebase today. it will, however, be addressed in our v11 release.

@kubijo
Copy link
Contributor

kubijo commented Jun 14, 2021

Just a heads-up that there's an automatic conversion tool that you could possibly use until the sources are generated in the new format (but you probably already knew about that)…

Another option is (reportedly) this if you want to keep compatibility with node-sass &/or older dart-sass implementations

@joshblack
Copy link
Contributor Author

Seems like what bootstrap ended up doing is temporarily replacing / with multiplication as another option 👀

@kubijo
Copy link
Contributor

kubijo commented Jun 22, 2021

I guess that is another option 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants