-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Themes): add in G80 theme #8478
Conversation
Deploy preview for carbon-elements ready! Built with commit b970a25 |
Deploy preview for carbon-components-react ready! Built with commit b970a25 https://deploy-preview-8478--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit a02f4f9 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a02f4f9 https://deploy-preview-8478--carbon-components-react.netlify.app |
@tw15egan Some of the components aren't rendering correctly because its tokens haven't been updated yet. Should we have the v10 tokens values defined for Gray 80? Or will that not matter once we update everything. |
@aagonzales yeah so I added this one in the opposite way of the other theme updates with new tokens in that I set the new token value to the IDL color and referenced the old tokens to the new ones. Will g80 be available as a theme in v10? If not, then we probably don't need to add them if we don't expose the theme on the website or anything |
No its irrelevant in v10. oh I see now, I hadn't gotten all the way to the bottom. Something with the selected states and some of the hovers is doing something weird. Let me see if I can figure out what is now that I know those bits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
|
Ok lets just leave it alone then. I wont look too hard at the components until they've all been updated with the new tokens. |
@aagonzales I turned on the feature flag so it should all be using the new tokens in all components except the ones in this PR: #8427 (once the deploy is updated) I'll turn it off before merging but should be the best way to test 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks TJ! That feature flagged really helped. Just one change I found.
@aagonzales updated 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 cool! looks good now!
Closes #8471
Adds in the g80 theme for inline theming efforts
Changelog
New
g80
is now available as a theme.Changed
g80
to the theme switcher in deploy previewsTesting / Reviewing
@aagonzales I didn't see a token for
linkPrimaryHover
, I think that's the only one missing