Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Components): add new color tokens (2/2) #8427

Merged
merged 12 commits into from
Apr 26, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Apr 15, 2021

Closes #8302

Changed

  • Updated color tokens for:
    • Overflow menu
    • Pagination
    • Pagination nav
    • Popover
    • Progress indicator
    • Radio button
    • Search
    • Select
    • Slider
    • Structured list
    • Tabs

Testing / Reviewing

Test against visual regressions.

@jnm2377 jnm2377 requested review from aagonzales and tw15egan April 15, 2021 22:15
@jnm2377 jnm2377 requested a review from a team as a code owner April 15, 2021 22:15
@jnm2377 jnm2377 requested a review from tay1orjones April 15, 2021 22:15
@netlify
Copy link

netlify bot commented Apr 15, 2021

Deploy preview for carbon-elements ready!

Built with commit 1b17559

https://deploy-preview-8427--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 15, 2021

Deploy preview for carbon-components-react ready!

Built with commit 1b17559

https://deploy-preview-8427--carbon-components-react.netlify.app

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so my comments are really annoying. A lot of them are were either the old token was wrong through old misuse so it wasn't migrating correctly or changes because we're removing the light variants that prioritized field tokens over ui tokens.

packages/components/src/components/tabs/_tabs.scss Outdated Show resolved Hide resolved
packages/components/src/components/tabs/_tabs.scss Outdated Show resolved Hide resolved
packages/components/src/components/tabs/_tabs.scss Outdated Show resolved Hide resolved
packages/components/src/components/tabs/_tabs.scss Outdated Show resolved Hide resolved
packages/components/src/components/tabs/_tabs.scss Outdated Show resolved Hide resolved
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! 👍 ✅

joshblack added a commit to joshblack/carbon that referenced this pull request Jun 29, 2021
sstrubberg added a commit that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 25% of components to use new design tokens (3/4)
4 participants