-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Components): add new color tokens (2/2) #8427
Conversation
Deploy preview for carbon-elements ready! Built with commit 1b17559 |
Deploy preview for carbon-components-react ready! Built with commit 1b17559 https://deploy-preview-8427--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, so my comments are really annoying. A lot of them are were either the old token was wrong through old misuse so it wasn't migrating correctly or changes because we're removing the light variants that prioritized field tokens over ui tokens.
packages/components/src/components/overflow-menu/_overflow-menu.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/overflow-menu/_overflow-menu.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/overflow-menu/_overflow-menu.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/overflow-menu/_overflow-menu.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/overflow-menu/_overflow-menu.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! 👍 ✅
…ystem#8427)" This reverts commit 8a94d14.
This reverts commit 8a94d14. Co-authored-by: Scott Strubberg <[email protected]>
Closes #8302
Changed
Testing / Reviewing
Test against visual regressions.