feat(FileUploader): FileUploader size prop update #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
changed the title
|
Deploy preview for carbon-elements ready! Built with commit 12015cf |
|
Deploy preview for carbon-components-react failed. Built without sensitive environment variables with commit 12015cf https://app.netlify.com/sites/carbon-components-react/deploys/609c6e040878020007476f88 |
tw15egan
force-pushed
the
file-uploader-size-update
branch
from
2ea7806 to
0c6da29
Compare
tw15egan
requested review from
a team and
johnbister
and removed request for
a team
tw15egan
force-pushed
the
file-uploader-size-update
branch
from
3934867 to
a65eff1
Compare
tw15egan
force-pushed
the
file-uploader-size-update
branch
from
2d560e3 to
31f25f7
Compare
|
ping @andreancardona to review when you get a chance, should be the last PR for the size updates |
|
bump @andreancardona when you get a sec! |
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8459
Refs #8369
Updates the
FileUploaderand subcomponents to use the standardized size values found across the system.Branched off of #8459 so will need to wait for that to be merged.
Changelog
New
fieldmaps tomdsmallmaps tosmTesting / Reviewing
Ensure all variants of
FileUploaderItemandFileUploaderButtonrender as expected