feat(StructuredList): Accessibility refactor #8172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 1789d5d |
|
Deploy preview for carbon-components-react ready! Built with commit 1789d5d https://deploy-preview-8172--carbon-components-react.netlify.app |
joshblack
suggested changes
Mar 24, 2021
joshblack
reviewed
Mar 25, 2021
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
Noticed a small little visual bug at the top right of the component
|
|
@tw15egan just fixed that styling issue! |
…37-improved-selection-a11y
…37-improved-selection-a11y
joshblack
suggested changes
Apr 12, 2021
|
Looking great! Just has that small style nit for naming conventions and then snapshots that are failing in CircleCI 👀 |
joshblack
approved these changes
Apr 13, 2021
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1937
This PR is a big overhaul/refactor of StructuredList to provide an accessible experience for keyboard and screen reader users changes include
<label>as row elements to handle clicks -- no using React.contextDeprecations
This PR introduces the following deprecations to existing StructuredList API (breaking changes should be behind a feature-flag:
labelprop which allowed table rows to select their nested radio buttons via event propagationdefaultCheckedmaybe unnecessary, but React was throwing a warning about controlled/uncontrolled componentsonChangeour context setup utilizes the onChange prop on the inputs nowvalueis now set according to contextTesting
Ideally, functionality, styling, and mouse based interaction should be identical with keyboard interaction and screen reader accessibility improving greatly 🏄🏽